[cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display

[cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display

[Lad Prabhakar]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi All,

This patch series adds support idk-1110wr display on RZ/G2M board.

Cheers,
--Prabhakar

Fabrizio Castro (1):
  arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display

Lad Prabhakar (1):
  dt-bindings: display: Add idk-1110wr binding

 .../display/panel/advantech,idk-1110wr.txt         | 45 +++++++++++++++++++
 arch/arm64/boot/dts/renesas/Makefile               |  1 +
 .../r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts        | 52 ++++++++++++++++++++++
 3 files changed, 98 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt
 create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts

-- 
2.7.4


[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4587): https://lists.cip-project.org/g/cip-dev/message/4587
Mute This Topic: https://lists.cip-project.org/mt/73158050/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

[cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding

[Lad Prabhakar]

[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

Add binding for the idk-1110wr LVDS panel from Advantech.

Some panel-specific documentation can be found here:
https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm

This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0
upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml
bindings.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../display/panel/advantech,idk-1110wr.txt         | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt

diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt
new file mode 100644
index 0000000..c5388b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt
@@ -0,0 +1,45 @@
+Advantech IDK-1110WR 10.1" WSVGA LVDS Display Panel
+===================================================
+
+The Advantech IDK-1110WR is a 10.1" industrial grade LCD display with
+4-wire resistive touch.
+
+These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt
+with the following device-specific properties.
+
+Required properties:
+
+- compatible: Shall contain "advantech,idk-1110wr" and "panel-lvds", in that
+  order.
+
+
+Example
+-------
+
+panel {
+	compatible = "advantech,idk-1110wr", "panel-lvds";
+
+	width-mm = <223>;
+	height-mm = <125>;
+
+	data-mapping = "jeida-24";
+
+	panel-timing {
+		/* 1024x600 @60Hz */
+		clock-frequency = <51200000>;
+		hactive = <1024>;
+		vactive = <600>;
+		hsync-len = <240>;
+		hfront-porch = <40>;
+		hback-porch = <40>;
+		vsync-len = <10>;
+		vfront-porch = <15>;
+		vback-porch = <10>;
+	};
+
+	port {
+		panel_in: endpoint {
+			remote-endpoint = <&lvds_encoder>;
+		};
+	};
+};
-- 
2.7.4


[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4588): https://lists.cip-project.org/g/cip-dev/message/4588
Mute This Topic: https://lists.cip-project.org/mt/73158052/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 817 bytes --]

Hi!

> Add binding for the idk-1110wr LVDS panel from Advantech.
> 
> Some panel-specific documentation can be found here:
> https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
> 
> This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0
> upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml
> bindings.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Okay. In future, I believe we can take yaml binding, even for kernel
where yaml support is not included. The markup is designed to be
human-readable anyway.

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4590): https://lists.cip-project.org/g/cip-dev/message/4590
Mute This Topic: https://lists.cip-project.org/mt/73158052/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding

[Lad Prabhakar]

[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]

Hi Pavel,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Pavel Machek via lists.cip-project.org
> Sent: 20 April 2020 21:16
> To: cip-dev@lists.cip-project.org
> Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Chris Paterson
> <Chris.Paterson2@renesas.com>
> Subject: Re: [cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding
>
> Hi!
>
> > Add binding for the idk-1110wr LVDS panel from Advantech.
> >
> > Some panel-specific documentation can be found here:
> > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
> >
> > This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0
> > upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml
> > bindings.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Okay. In future, I believe we can take yaml binding, even for kernel
> where yaml support is not included. The markup is designed to be
> human-readable anyway.
>
Thanks I shall do that in future. Just for reference in case a yaml binding has a reference to other yaml binding  so should there be a patch for converting to yaml format (for example panel.txt -> panel.yaml) ?

Cheers,
--Prabhakar

> Best regards,
> Pavel
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4591): https://lists.cip-project.org/g/cip-dev/message/4591
Mute This Topic: https://lists.cip-project.org/mt/73158052/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 1211 bytes --]

Hi!

> > > Add binding for the idk-1110wr LVDS panel from Advantech.
> > >
> > > Some panel-specific documentation can be found here:
> > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
> > >
> > > This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0
> > > upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml
> > > bindings.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Okay. In future, I believe we can take yaml binding, even for kernel
> > where yaml support is not included. The markup is designed to be
> > human-readable anyway.
> >
> Thanks I shall do that in future. Just for reference in case a yaml binding has a reference to other yaml binding  so should there be a patch for converting to yaml format (for example panel.txt -> panel.yaml) ?
> 

Goal here is to save work, and this is just a documentation, so no, I
don't believe we need to do more conversions.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4594): https://lists.cip-project.org/g/cip-dev/message/4594
Mute This Topic: https://lists.cip-project.org/mt/73158052/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

[cip-dev] [PATCH 2/2] arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display

[Lad Prabhakar]

[-- Attachment #1: Type: text/plain, Size: 2928 bytes --]

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

commit e30f56800e69db6d2763a1f7f64dfcc79f9b5ea7 upstream.

The HiHope RZ/G2M is advertised as compatible with panel idk-1110wr
from Advantech, however the panel isn't sold alongside the board.
A new dts, adding everything that's required to get the panel to
work the HiHope RZ/G2M, is the most convenient way to support the
HiHope RZ/G2M when it's connected to the idk-1110wr.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/1583957020-16359-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/Makefile               |  1 +
 .../r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts        | 52 ++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 17785e1..c05feec 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex.dtb
+dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n.dtb
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n-ex.dtb
 dtb-$(CONFIG_ARCH_R8A774C0) += r8a774c0-cat874.dtb r8a774c0-ek874.dtb
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
new file mode 100644
index 0000000..2ab5edd
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the HiHope RZ/G2M sub board connected to an
+ * Advantech IDK-1110WR 10.1" LVDS panel
+ *
+ * Copyright (C) 2020 Renesas Electronics Corp.
+ */
+
+#include "r8a774a1-hihope-rzg2m-ex.dts"
+#include "rzg2-advantech-idk-1110wr-panel.dtsi"
+
+/ {
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm0 0 50000>;
+
+		brightness-levels = <0 2 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+	};
+
+};
+
+&gpio1 {
+	/*
+	 * When GP1_20 is LOW LVDS0 is connected to the LVDS connector
+	 * When GP1_20 is HIGH LVDS0 is connected to the LT8918L
+	 */
+	lvds-connector-en-gpio {
+		gpio-hog;
+		gpios = <20 GPIO_ACTIVE_HIGH>;
+		output-low;
+		line-name = "lvds-connector-en-gpio";
+	};
+};
+
+&lvds0 {
+	status = "okay";
+};
+
+&pfc {
+	pwm0_pins: pwm0 {
+		groups = "pwm0";
+		function = "pwm0";
+	};
+};
+
+&pwm0 {
+	pinctrl-0 = <&pwm0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
2.7.4


[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4589): https://lists.cip-project.org/g/cip-dev/message/4589
Mute This Topic: https://lists.cip-project.org/mt/73158053/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 395 bytes --]

Hi!

> This patch series adds support idk-1110wr display on RZ/G2M board.

I assume it is for 4.19; subject does not say. Otherwise it looks good,
so I'll test it and apply unless someone sees problem with it.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4592): https://lists.cip-project.org/g/cip-dev/message/4592
Mute This Topic: https://lists.cip-project.org/mt/73158050/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display

[Lad Prabhakar]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

Hi Pavel,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Pavel Machek via lists.cip-project.org
> Sent: 20 April 2020 21:25
> To: cip-dev@lists.cip-project.org
> Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Chris Paterson
> <Chris.Paterson2@renesas.com>
> Subject: Re: [cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display
>
> Hi!
>
> > This patch series adds support idk-1110wr display on RZ/G2M board.
>
> I assume it is for 4.19; subject does not say. Otherwise it looks good,
> so I'll test it and apply unless someone sees problem with it.
>
Oops my bad, yes it's for 4.19.

Cheers,
--Prabhakar

> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4593): https://lists.cip-project.org/g/cip-dev/message/4593
Mute This Topic: https://lists.cip-project.org/mt/73158050/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 0/2] Add HiHope RZ/G2M board with idk-1110wr display

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]

Hi!

> > > This patch series adds support idk-1110wr display on RZ/G2M board.
> >
> > I assume it is for 4.19; subject does not say. Otherwise it looks good,
> > so I'll test it and apply unless someone sees problem with it.
> >
> Oops my bad, yes it's for 4.19.

Thanks, I applied the series.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4595): https://lists.cip-project.org/g/cip-dev/message/4595
Mute This Topic: https://lists.cip-project.org/mt/73158050/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-