[cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver

[cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver

[Johnson CH Chen (陳昭勳)]

The patch series support TI CPUFreq/OPP hw-supported driver that is required 
for cpufreq support on AM335x, AM437x, DRA7x, and AM57x platforms. Besides,
opp-supported-hw allows a platform to enable OPPs based on the version of the 
hardware they are used for.     

Tested on MOXA UC-8100A-ME that uses AM335x's SoC we have in house.

Dave Gerlach (1):
  cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime

Viresh Kumar (2):
  PM / OPP: Add "opp-supported-hw" binding
  PM / OPP: Parse 'opp-supported-hw' binding

 Documentation/devicetree/bindings/opp/opp.txt |  65 ++++++
 drivers/base/power/opp/core.c                 | 149 ++++++++++++++
 drivers/base/power/opp/opp.h                  |   6 +
 drivers/cpufreq/Kconfig.arm                   |  11 ++
 drivers/cpufreq/Makefile                      |   1 +
 drivers/cpufreq/ti-cpufreq.c                  | 272 ++++++++++++++++++++++++++
 include/linux/pm_opp.h                        |  20 ++
 7 files changed, 524 insertions(+)
 create mode 100644 drivers/cpufreq/ti-cpufreq.c

-- 
2.11.0

Re: [cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver

[Nobuhiro Iwamatsu]

Hi Johnson CH Chen,

> -----Original Message-----
> From: Johnson CH Chen (陳昭勳) [mailto:JohnsonCH.Chen@moxa.com]
> Sent: Thursday, April 30, 2020 12:33 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de
> Subject: [cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver
> 
> The patch series support TI CPUFreq/OPP hw-supported driver that is required
> for cpufreq support on AM335x, AM437x, DRA7x, and AM57x platforms. Besides,
> opp-supported-hw allows a platform to enable OPPs based on the version of the
> hardware they are used for.
> 
> Tested on MOXA UC-8100A-ME that uses AM335x's SoC we have in house.
> 
> Dave Gerlach (1):
>   cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime
> 
> Viresh Kumar (2):
>   PM / OPP: Add "opp-supported-hw" binding
>   PM / OPP: Parse 'opp-supported-hw' binding

Looks good to me.
If there is no opinion, I will apply this series.

Best regards,
  Nobuhiro
> 
>  Documentation/devicetree/bindings/opp/opp.txt |  65 ++++++
>  drivers/base/power/opp/core.c                 | 149 ++++++++++++++
>  drivers/base/power/opp/opp.h                  |   6 +
>  drivers/cpufreq/Kconfig.arm                   |  11 ++
>  drivers/cpufreq/Makefile                      |   1 +
>  drivers/cpufreq/ti-cpufreq.c                  | 272 ++++++++++++++++++++++++++
>  include/linux/pm_opp.h                        |  20 ++
>  7 files changed, 524 insertions(+)
>  create mode 100644 drivers/cpufreq/ti-cpufreq.c
> 
> --
> 2.11.0

Re: [cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver

[Pavel Machek]

[-- Attachment #1.1: Type: text/plain, Size: 684 bytes --]

Hi!

> > Tested on MOXA UC-8100A-ME that uses AM335x's SoC we have in house.
> > 
> > Dave Gerlach (1):
> >   cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime
> > 
> > Viresh Kumar (2):
> >   PM / OPP: Add "opp-supported-hw" binding
> >   PM / OPP: Parse 'opp-supported-hw' binding
> 
> Looks good to me.
> If there is no opinion, I will apply this series.

I have made some comments. 3/3 has double-free in error path, that one
may be worth fixing before the merge.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4613): https://lists.cip-project.org/g/cip-dev/message/4613
Mute This Topic: https://lists.cip-project.org/mt/73369238/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [PATCH 4.4.y-cip 0/3] Add TI CPUFreq/OPP hw-supported driver

[Chen-Yu Tsai]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

Hi,

On Fri, May 01, 2020 at 11:36:15AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > Tested on MOXA UC-8100A-ME that uses AM335x's SoC we have in house.
> > > 
> > > Dave Gerlach (1):
> > >   cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime
> > > 
> > > Viresh Kumar (2):
> > >   PM / OPP: Add "opp-supported-hw" binding
> > >   PM / OPP: Parse 'opp-supported-hw' binding
> > 
> > Looks good to me.
> > If there is no opinion, I will apply this series.
> 
> I have made some comments. 3/3 has double-free in error path, that one
> may be worth fixing before the merge.

I will take over backporting these patches from Johnson, and other
in MOXA's kernel tree that were included from TI's SDK.

TI's SDK actually includes many more patches related to PM/OPP and
cpufreq. Most of them are already in mainline. I plan to backport
these in several steps, split by the original submission and kernel
version.

The first part will be from kernel v4.5, which includes the series
"PM / OPP: opp-supported-hw and <prop>-name bindings" [1] and later
-rc fixes in v4.5

The second part will be from kernel v4.6, which is the series
"PM / OPP: Introduce APIs to transition OPPs" [2] and -rc fixes.

The last part will be the ti-cpufreq driver and related fixes request
by Pavel, as well as conversion of am33xx dts to opp-v2.


Regards
ChenYu

[1] https://lore.kernel.org/linux-pm/cover.1447209519.git.viresh.kumar@linaro.org/
[2] https://lore.kernel.org/linux-pm/cover.1454992186.git.viresh.kumar@linaro.org/


[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4652): https://lists.cip-project.org/g/cip-dev/message/4652
Mute This Topic: https://lists.cip-project.org/mt/73369238/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-