From: "Pavel Machek" <pavel@ucw.cz>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
"nobuhiro1.iwamatsu@toshiba.co.jp"
<nobuhiro1.iwamatsu@toshiba.co.jp>,
"pavel@denx.de" <pavel@denx.de>
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: dts: am33xx: Added macros for numeric pinmux addresses
Date: Wed, 3 Jun 2020 17:24:16 +0200 [thread overview]
Message-ID: <20200603152416.GB16550@amd> (raw)
In-Reply-To: <HK2PR01MB3281497DDEAFCA27D58CB642FA880@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]
Hi!
> From: Christina Quast <cquast@hanoverdisplays.com>
>
> commit 7ebd1ea798a4932231b18499df136fb552f6f648 upstream.
>
> The values are extraced from the "AM335x SitaraTM Processors Technical
> Reference Manual", Section 9.3.1 CONTROL_MODULE Registers, based on the
> file autogenerated by TI PinMux.
I don't see anything wrong with the patch. OTOH I'd expect to see this
in a series with the code actually using these defines.
Is there a reason to merge it on its own?
Best regards,
Pavel
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Johnson Chen <johnsonch.chen@moxa.com>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#4668): https://lists.cip-project.org/g/cip-dev/message/4668
Mute This Topic: https://lists.cip-project.org/mt/74646578/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-06-03 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 10:10 [cip-dev] [PATCH 4.4.y-cip] ARM: dts: am33xx: Added macros for numeric pinmux addresses johnsonch.chen@moxa.com
2020-06-03 15:24 ` Pavel Machek [this message]
2020-06-04 2:18 ` johnsonch.chen@moxa.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603152416.GB16550@amd \
--to=pavel@ucw.cz \
--cc=JohnsonCH.Chen@moxa.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox