Re: [cip-dev] [PATCH 4.4.y-cip 0/3] ARM: dts: am335x: Replace numeric pinmux address with macro defines

["Pavel Machek" <pavel@ucw.cz>]

[-- Attachment #1.1: Type: text/plain, Size: 1309 bytes --]

Hi!

> > Tony Lindgren (1):
> >   ARM: dts: am33xx: Added AM33XX_PADCONF macro
> >
> >  arch/arm/boot/dts/am335x-moxa-uc-8100-me-t.dts | 116 +++++++++++-----------
> >  include/dt-bindings/pinctrl/am33xx.h           | 130 ++++++++++++++++++++++++-
> >  include/dt-bindings/pinctrl/omap.h             |   1 +
> >  3 files changed, 188 insertions(+), 59 deletions(-)
> >
> These should be the following:
> 
> Christina Quast (3):
>   ARM: dts: am33xx: Added macros for numeric pinmux addresses
>   ARM: dts: am33xx: Added AM33XX_PADCONF macro
>   ARM: dts: am335x: moxa-uc-8100-me-t: Replaced register offsets with
>     defines

There's nothing obviously wrong with the patches (and they won't break
anything but am335x-moxa platform, so they are low risk).

On the other hand, I don't see any obvious benefit. Whether we use hex
constants or symbolic constants affects readability, but has no effect
on functionality.

Do you have any patches on top of these that rely on symbolic
constants in the dts? Are there any changes in the generated .dtb?
What is the benefit of this series (besides cleanup)?

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4770): https://lists.cip-project.org/g/cip-dev/message/4770
Mute This Topic: https://lists.cip-project.org/mt/74749053/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-