From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72F9C433E6 for ; Tue, 14 Jul 2020 17:44:08 +0000 (UTC) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B960422582 for ; Tue, 14 Jul 2020 17:44:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.cip-project.org header.i=@lists.cip-project.org header.b="bwEfhNUk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B960422582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=bounce+64572+4926+4520388+8129055@lists.cip-project.org X-Received: by 127.0.0.2 with SMTP id 4pEGYY4521723xssoDGI6zn7; Tue, 14 Jul 2020 10:44:08 -0700 X-Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by mx.groups.io with SMTP id smtpd.web10.1869.1594748647541808421 for ; Tue, 14 Jul 2020 10:44:07 -0700 X-Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 71BCC1C0BD5; Tue, 14 Jul 2020 19:44:04 +0200 (CEST) Date: Tue, 14 Jul 2020 19:44:03 +0200 From: "Pavel Machek" To: "Chen-Yu Tsai (Moxa)" Cc: nobuhiro1.iwamatsu@toshiba.co.jp, pavel@denx.de, cip-dev@lists.cip-project.org, JohnsonCH.Chen@moxa.com Subject: Re: [cip-dev] [PATCH 4.4.y-cip 06/23] PM / OPP: Manage device clk Message-ID: <20200714174403.GE18210@amd> References: <20200708154554.26450-1-wens@csie.org> <20200708154554.26450-7-wens@csie.org> MIME-Version: 1.0 In-Reply-To: <20200708154554.26450-7-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: Bulk List-Unsubscribe: Sender: cip-dev@lists.cip-project.org List-Id: Mailing-List: list cip-dev@lists.cip-project.org; contact cip-dev+owner@lists.cip-project.org Reply-To: cip-dev@lists.cip-project.org X-Gm-Message-State: MdoD1B2l5mTBSwVgDDXaooAdx4520388AA= Content-Type: multipart/mixed; boundary="3f1EcuBeKkk4II5wONw7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.cip-project.org; q=dns/txt; s=20140610; t=1594748648; bh=7qYJU6LrglR799O3oCwklx+DbCzc+aWYIpjdKKlfW2A=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=bwEfhNUk+pZjAEQQXMeB8TIbl6uyp8pu6Kncy1v/GHYnDEvvlJxO0WggktQ26FJQYND zyIglnTfAjOsKID4A2+Vt+aOBMBQVmFnFQCaVdTROe0Khxyva6SZ2q04S6i7RJM1W8Z4b DCSclf4/qabw6peop8mPZsI+ILh0FmAmHeM= --3f1EcuBeKkk4II5wONw7 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BQPnanjtCNWHyqYD" Content-Disposition: inline --BQPnanjtCNWHyqYD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Viresh Kumar >=20 > commit d54974c2513f487e9e70fbdc79c5da51c53e23da upstream. >=20 > OPP core has got almost everything now to manage device's OPP > transitions, the only thing left is device's clk. Get that as well. > @@ -620,6 +622,15 @@ static struct device_opp *_add_device_opp(struct dev= ice *dev) > of_node_put(np); > } > =20 > + /* Find clk for the device */ > + dev_opp->clk =3D clk_get(dev, NULL); > + if (IS_ERR(dev_opp->clk)) { > + ret =3D PTR_ERR(dev_opp->clk); > + if (ret !=3D -EPROBE_DEFER) > + dev_dbg(dev, "%s: Couldn't find clock: %d\n", __func__, > + ret); > + } > + Can you double check this piece? In case of clk_get() returning EPROBE_DEFER, I'd expect this code to return it to the callers, without continuing initialization. Best regards, Pavel =09 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --BQPnanjtCNWHyqYD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8N7uMACgkQMOfwapXb+vJSjwCfRSB1LU4NT/TGujWUSFUbkMVq HdEAoJNKk2h6qytJZ4ndyUiXlB+ifGFI =xNIT -----END PGP SIGNATURE----- --BQPnanjtCNWHyqYD-- --3f1EcuBeKkk4II5wONw7 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Links: You receive all messages sent to this group. View/Reply Online (#4926): https://lists.cip-project.org/g/cip-dev/message= /4926 Mute This Topic: https://lists.cip-project.org/mt/75379085/4520388 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/7279483= 98/xyzzy [cip-dev@archiver.kernel.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --3f1EcuBeKkk4II5wONw7--