Re: [cip-dev] [PATCH 4.19.y-cip 1/2] ASoC: rsnd: fixup SSI clock during suspend/resume modes

["Pavel Machek" <pavel@ucw.cz>]

[-- Attachment #1.1: Type: text/plain, Size: 1950 bytes --]

Hi!

> commit 624d1a7cd8991e33dad96ab4629a52c412540e65 upstream.
> 
> Prepare <-> Cleanup functions pair has balanced calls.
> But in case of suspend mode no call to rsnd_soc_dai_shutdown()
> function, so cleanup isn't called. OTOH during resume mode
> function rsnd_soc_dai_prepare() is called, but calling
> rsnd_ssi_prepare() is skipped (rsnd_status_update() returns zero,
> bacause was not cleanup before).
> We need to call rsnd_ssi_prepare(), because it enables SSI clocks
> by calling rsnd_ssi_master_clk_start().
> 
> This patch allows to call prepare/cleanup functions always.

Ok, this is "interesting". It has something to do with rsnd_dai_call()
macro.

You really should not be programming drivers in preprocessor like
this.

OTOH patch is simple enough, and only affects "your" code, so ... I'll
apply it if there are no other comments.

>  #define __rsnd_mod_shift_hw_params	28 /* always called */
>  #define __rsnd_mod_shift_pointer	28 /* always called */
> +#define __rsnd_mod_shift_prepare	28 /* always called */
> +#define __rsnd_mod_shift_cleanup	28 /* always called */
>  
>  #define __rsnd_mod_add_probe		0
>  #define __rsnd_mod_add_remove		0
> -#define __rsnd_mod_add_prepare		 1
> -#define __rsnd_mod_add_cleanup		-1
> +#define __rsnd_mod_add_prepare		0
> +#define __rsnd_mod_add_cleanup		0
>  #define __rsnd_mod_add_init		 1
>  #define __rsnd_mod_add_quit		-1
>  #define __rsnd_mod_add_start		 1
> @@ -365,7 +365,7 @@ struct rsnd_mod {
>  #define __rsnd_mod_call_probe		0
>  #define __rsnd_mod_call_remove		0
>  #define __rsnd_mod_call_prepare		0
> -#define __rsnd_mod_call_cleanup		1
> +#define __rsnd_mod_call_cleanup		0
>  #define __rsnd_mod_call_init		0
>  #define __rsnd_mod_call_quit		1
>  #define __rsnd_mod_call_start		0

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4940): https://lists.cip-project.org/g/cip-dev/message/4940
Mute This Topic: https://lists.cip-project.org/mt/75687530/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-