Re: [cip-dev] [linux-cip:linux-4.19.y-cip 7/17] drivers/gpu/drm/drm_atomic.c:1264:1: warning: no previous prototype for 'drm_atomic_get_old_private_obj_state'

Biju Das
2020-08-13T11:43:24Z

[-- Attachment #1: Type: text/plain, Size: 6460 bytes --]

Hi Pavel,

Thanks for the feedback.

> drivers/gpu/drm/drm_atomic.c:1264:1: warning: no previous prototype for
> 'drm_atomic_get_old_private_obj_state'
>
> Hi!
>
> > I have received a warning message mail from Kernel test robot. I have
> investigated this issue and found there were lots of warnings with
> architecture by following the steps mentioned in this mail.
> >
> > Then I investigated this particular issue and found that issue is
> > caused by bad commit done by me while backporting. The below backport
> commit has extra functions from patch1(0001-drm-Add-
> drm_atomic_get_old-new_private_obj_state.patch), but the corresponding
> header is missing.
> >
> > cip commit: cacc2a81b9872aa8830353110b1252021f124ae8
> > upstream commit: 1b27fbdde1df172dba604855c45078d741f8c858
> >
> > I have attached 3 patches, that looks like fixes the issue mentioned by
> kernel robot.
> >
> > How do we proceed here?
> > drop cip commit: cacc2a81b9872aa8830353110b1252021f124ae8 and apply
> the 3 patches to fix this issue?
> >
>
> No, let's not revert anything.
>
> This is trivial fix for first issue, make it into patch:

Ok, will make it into a patch

> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index
> c0b48e25a620..9042fdae9211 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -402,6 +402,12 @@ void drm_atomic_private_obj_fini(struct
> drm_private_obj *obj); struct drm_private_state * __must_check
> drm_atomic_get_private_obj_state(struct drm_atomic_state *state,
> struct drm_private_obj *obj);
> +struct drm_private_state *
> +drm_atomic_get_old_private_obj_state(struct drm_atomic_state *state,
> + struct drm_private_obj *obj);
> +struct drm_private_state *
> +drm_atomic_get_new_private_obj_state(struct drm_atomic_state *state,
> + struct drm_private_obj *obj);
>
> struct drm_connector *
> drm_atomic_get_old_connector_for_encoder(struct drm_atomic_state
> *state,
>
> And this is somehow strange / non-trivial thingie. Make it into second patch,
> and maybe try to explain what is going on there.

Ok will do.

Cheers,
Biju

>
> @@ -656,6 +662,7 @@ void drm_state_dump(struct drm_device *dev, struct
> drm_printer *p);
> (__i)++)
> \
> for_each_if ((__state)->connectors[__i].ptr &&
> \
> ((connector) = (__state)->connectors[__i].ptr,
> \
> + (void)(connector) /* Only to avoid unused-but-
> set-variable
> +warning */, \
> (old_connector_state) = (__state)-
> >connectors[__i].old_state,\
> (new_connector_state) = (__state)-
> >connectors[__i].new_state, 1))
>
> @@ -677,6 +684,7 @@ void drm_state_dump(struct drm_device *dev, struct
> drm_printer *p);
> (__i)++)
> \
> for_each_if ((__state)->connectors[__i].ptr &&
> \
> ((connector) = (__state)->connectors[__i].ptr,
> \
> + (void)(connector) /* Only to avoid unused-but-
> set-variable
> +warning */, \
> (old_connector_state) = (__state)-
> >connectors[__i].old_state, 1))
>
> /**
> @@ -697,7 +705,9 @@ void drm_state_dump(struct drm_device *dev, struct
> drm_printer *p);
> (__i)++)
> \
> for_each_if ((__state)->connectors[__i].ptr &&
> \
> ((connector) = (__state)->connectors[__i].ptr,
> \
> - (new_connector_state) = (__state)-
> >connectors[__i].new_state, 1))
> + (void)(connector) /* Only to avoid unused-but-
> set-variable warning */, \
> + (new_connector_state) = (__state)-
> >connectors[__i].new_state, \
> + (void)(new_connector_state) /* Only to avoid
> +unused-but-set-variable warning */, 1))
>
> /**
> * for_each_oldnew_crtc_in_state - iterate over all CRTCs in an atomic
> update @@ -717,7 +727,9 @@ void drm_state_dump(struct drm_device
> *dev, struct drm_printer *p);
> (__i)++)\
> for_each_if ((__state)->crtcs[__i].ptr &&\
> ((crtc) = (__state)->crtcs[__i].ptr,\
> + (void)(crtc) /* Only to avoid unused-but-set-
> variable warning
> +*/, \
> (old_crtc_state) = (__state)->crtcs[__i].old_state,
> \
> + (void)(old_crtc_state) /* Only to avoid unused-
> but-set-variable
> +warning */, \
> (new_crtc_state) = (__state)-
> >crtcs[__i].new_state, 1))
>
> /**
> @@ -756,7 +768,9 @@ void drm_state_dump(struct drm_device *dev, struct
> drm_printer *p);
> (__i)++)\
> for_each_if ((__state)->crtcs[__i].ptr &&\
> ((crtc) = (__state)->crtcs[__i].ptr,\
> - (new_crtc_state) = (__state)-
> >crtcs[__i].new_state, 1))
> + (void)(crtc) /* Only to avoid unused-but-set-
> variable warning */, \
> + (new_crtc_state) = (__state)-
> >crtcs[__i].new_state, \
> + (void)(new_crtc_state) /* Only to avoid unused-
> but-set-variable
> +warning */, 1))
>
> /**
> * for_each_oldnew_plane_in_state - iterate over all planes in an atomic
> update @@ -776,6 +790,7 @@ void drm_state_dump(struct drm_device
> *dev, struct drm_printer *p);
> (__i)++)\
> for_each_if ((__state)->planes[__i].ptr &&\
> ((plane) = (__state)->planes[__i].ptr,\
> + (void)(plane) /* Only to avoid unused-but-set-
> variable warning
> +*/, \
> (old_plane_state) = (__state)-
> >planes[__i].old_state,\
> (new_plane_state) = (__state)-
> >planes[__i].new_state, 1))
>
> @@ -836,7 +851,9 @@ void drm_state_dump(struct drm_device *dev, struct
> drm_printer *p);
> (__i)++)\
> for_each_if ((__state)->planes[__i].ptr &&\
> ((plane) = (__state)->planes[__i].ptr,\
> - (new_plane_state) = (__state)-
> >planes[__i].new_state, 1))
> + (void)(plane) /* Only to avoid unused-but-set-
> variable warning */, \
> + (new_plane_state) = (__state)-
> >planes[__i].new_state, \
> + (void)(new_plane_state) /* Only to avoid
> +unused-but-set-variable warning */, 1))
>
> /**
> * for_each_oldnew_private_obj_in_state - iterate over all private objects in
> an atomic update
>
>
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5118): https://lists.cip-project.org/g/cip-dev/message/5118