From: "Pavel Machek" <pavel@ucw.cz>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Pavel Machek <pavel@denx.de>,
"cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set
Date: Thu, 13 Aug 2020 22:48:42 +0200 [thread overview]
Message-ID: <20200813204842.GA24086@duo.ucw.cz> (raw)
In-Reply-To: <TYBPR01MB5309E07DED8A1ACFB0DDA8BA86430@TYBPR01MB5309.jpnprd01.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]
On Thu 2020-08-13 06:39:55, Biju Das wrote:
> Hi Pavel,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set
> >
> > Hi!
> >
> > I assume this patch is for 4.19-cip?
>
> Yes, it is for 4.19-cip.
>
> > > commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.
> > >
> > > The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
> > > commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
> > > the stub is declared in drm_of.h without a static inline. This causes
> > > multiple definitions of the function to be linked when the CONFIG_OF
> > > option isn't set. Fix it by making the stub static inline.
> >
> > So this is pretty obvious, and I'll likely apply it.
>
> Thanks for applying it.
Applied.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5121): https://lists.cip-project.org/g/cip-dev/message/5121
Mute This Topic: https://lists.cip-project.org/mt/76127518/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2020-08-13 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 14:40 [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set Biju Das
2020-08-12 19:24 ` Pavel Machek
2020-08-13 6:39 ` Biju Das
2020-08-13 20:48 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813204842.GA24086@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox