From: "Pavel Machek" <pavel@ucw.cz>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Pavel Machek <pavel@denx.de>,
"cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 4.19.y-cip 01/12] arm64: dts: renesas: r8a774a1-hihope-rzg2m[-ex/-ex-idk-1110wr]: Rename HiHope RZ/G2M boards
Date: Sun, 23 Aug 2020 21:35:02 +0200 [thread overview]
Message-ID: <20200823193502.GD25365@duo.ucw.cz> (raw)
In-Reply-To: <TYBPR01MB5309709F469C1BBDCB012749865A0@TYBPR01MB5309.jpnprd01.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1382 bytes --]
Hi!
> > Ok, so this is anti-social:
> >
> > > -dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m.dtb
> > > +dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2.dtb
> >
> > This renames dts away, but at the end of series, new dts is created with the
> > r8a774a1-hihope-rzg2m.dts name, but this time it is for rev4 (not rev2) board.
> >
> > So... people with rev2 boards and existing build script will get rev4 dts..
> > without any error.
>
> Yes, that is true. But if you agree, We need to use our latest/greatest SoC/board as the main SoC/Board and rest are with explicit revision in dts/dtb .
>
I believe it would be better to always use explicit revision in these
cases; anything else is fairly confusing, as kernel update breaks your
setup (aka a regresssion).
Now, if -rev2 had few copies, and people really have -rev4, there will
not be much breakage. But imagine if rare -rev5 is released in future...
But mainline already made the choice. I'd just prefer not making same
choice in future.
Now, what to do here? One way would be to apply a series, but add a
README.cip file explaining incompatible change (and any future stuff
people need to know).
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5230): https://lists.cip-project.org/g/cip-dev/message/5230
Mute This Topic: https://lists.cip-project.org/mt/76290781/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-08-23 19:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:36 [cip-dev] [PATCH 4.19.y-cip 00/12] Support RZ/G2[MN] rev4 board Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 01/12] arm64: dts: renesas: r8a774a1-hihope-rzg2m[-ex/-ex-idk-1110wr]: Rename HiHope RZ/G2M boards Biju Das
2020-08-19 18:05 ` Pavel Machek
2020-08-20 6:54 ` Biju Das
2020-08-23 19:35 ` Pavel Machek [this message]
2020-08-24 6:46 ` Biju Das
2020-08-25 21:51 ` Pavel Machek
2020-08-26 6:32 ` Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 02/12] arm64: dts: renesas: r8a774b1-hihope-rzg2n[-ex]: Rename HiHope RZ/G2N boards Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 03/12] arm64: dts: renesas: hihope-common: Separate out Rev.2.0 specific into hihope-rev2.dtsi file Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 04/12] arm64: dts: renesas: Add HiHope RZ/G2M[N] Rev.3.0/4.0 specific into common file Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 05/12] arm64: dts: renesas: Add HiHope RZ/G2M Rev.3.0/4.0 main board support Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 06/12] arm64: dts: renesas: Add HiHope RZ/G2M Rev.3.0/4.0 sub " Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 07/12] arm64: dts: renesas: hihope-rzg2-ex: Separate out lvds specific nodes into common file Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 08/12] arm64: dts: renesas: Add HiHope RZ/G2M Rev.3.0/4.0 board with idk-1110wr display Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 09/12] arm64: dts: renesas: Add HiHope RZ/G2N Rev.3.0/4.0 main board support Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 10/12] arm64: dts: renesas: Add HiHope RZ/G2N Rev.3.0/4.0 sub " Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 11/12] arm64: dts: renesas: Add HiHope RZ/G2N Rev2.0/3.0/4.0 board with idk-1110wr display Biju Das
2020-08-19 16:36 ` [cip-dev] [PATCH 4.19.y-cip 12/12] arm64: dts: renesas: r8a774a1: Remove audio port node Biju Das
2020-08-19 17:38 ` [cip-dev] [PATCH 4.19.y-cip 00/12] Support RZ/G2[MN] rev4 board Pavel Machek
2020-08-20 9:16 ` Chris Paterson
2020-08-23 19:37 ` Pavel Machek
2020-08-23 23:15 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823193502.GD25365@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox