Re: [cip-dev] If you are using PCIe EP, speak up was Re: [RFC PATCH 4.19.y-cip 00/50] Add PCIe EP support for Renesas R-Car Gen3 and RZ/G2x

Lad Prabhakar
2020-10-20T07:16:08Z

[-- Attachment #1: Type: text/plain, Size: 2716 bytes --]

Hi Pavel,

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Pavel Machek via lists.cip-project.org
> Sent: 14 October 2020 10:39
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Subject: [cip-dev] If you are using PCIe EP, speak up was Re: [RFC PATCH 4.19.y-cip 00/50] Add PCIe EP support for Renesas R-Car Gen3 and
> RZ/G2x
>
> Hi!
>
> > This patch series adds support for PCIe EP on Renesas R-Car Gen3 and
> > RZ/G2x platforms.
>
> I quickly went through a series and code seems reasonably nice.
>
> > * Since the changes are huge I am sending the patches as RFC.
>
> And yes, it is quite big, which might be a problem. OTOH only Renesas
> seems to have PCIe EP drivers enabled in their CIP defconfigs, so
> there's good chance noone else in CIP project is using this code.
>
> [If someone else _is_ using it or is considering using it, please
> speak up.]
>
We haven't received any response yet, is it OK if I send a non RFC version or shall we wait for couple of days more ?

Cheers,
Prabhakar

> Could we get better explanation for 24/ of the series? spinlock is
> okay as long as code inside does not sleep, does not neccessarily have
> to do with interrupts.
>
> Should 30/ and 31/ be submitted to stable?
>
> > * Required EP framework changes and fixes are ported as well.
> > * All the patches have been cheery picked from upstream kernel.
> > * Patches [43, 44, 45, 46, 48]/50 are picked from linux-next.
>
> Ok, so we definitely want them in upstream, not in -next. And it might
> be good to wait a bit after merge, so it gets some testing in upstream.
>
> > * I was skeptic with patch 36/50 "Rename pcie-rcar.c to pcie-rcar-host.c"
> > this is required as patch 38/50 adds a new file named pcie-rcar.c. Open
> > for suggestions if this can be handled differently.
> > * In patch 37/48 I have dropped the changes for host driver as the patch
> > doesn't apply cleanly and manually applying it was resulting in a
> > big diff.
>
> Let me take a look at these in bigger detail.
>
> > * As the changes touches three other controller drivers I have build tested them
> > as done similarly while upstreaming R-Car Gen3 PCIe EP driver.
>
> Will this be tested somehow by our automated tests?
>
> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5591): https://lists.cip-project.org/g/cip-dev/message/5591
Mute This Topic: https://lists.cip-project.org/mt/77501866/4520388