Re: [cip-dev] [RFC PATCH 4.19.y-cip 00/50] Add PCIe EP support for Renesas R-Car Gen3 and RZ/G2x

Lad Prabhakar
2020-10-15T16:27:33Z

[-- Attachment #1: Type: text/plain, Size: 2312 bytes --]

Hi Pavel,

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 14 October 2020 11:08
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Subject: Re: [RFC PATCH 4.19.y-cip 00/50] Add PCIe EP support for Renesas R-Car Gen3 and RZ/G2x
>
> Hi!
>
> > * I was skeptic with patch 36/50 "Rename pcie-rcar.c to pcie-rcar-host.c"
> > this is required as patch 38/50 adds a new file named pcie-rcar.c. Open
> > for suggestions if this can be handled differently.
> > * In patch 37/48 I have dropped the changes for host driver as the patch
> > doesn't apply cleanly and manually applying it was resulting in a
> > big diff.
>
> I have no good ideas how to avoid rename.
>
> Given the change in locking previously in the series, manual review of
> changes in this area might be good idea, anyway.
>
The locking changes are wrt EPF framework anyway. OK so I assume you are happy to manual changes to PCIe host driver while posting non RFC version.

> In 4.19, there were 75 patches in this area so far, and 5 patches that
> would reject due to the rename.
>
> pavel@amd:~/cip/krc$ git log --pretty=oneline v4.19.. drivers/pci/controller/ | wc -l
> 75
> pavel@amd:~/cip/krc$ git log --pretty=oneline v4.19.. drivers/pci/controller/pcie-rcar*.c | wc -l
> 5
>
> ...so we'll get a bit of additional workload from this. It would be
> more scary if there were -rt specific changes in this area, but
> hopefully there are none.
>
> I expect that you are willing to help if -stable or -rt introduces
> conflicting patches in this area?
>
indeed.

Cheers,
Prabhakar

> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5581): https://lists.cip-project.org/g/cip-dev/message/5581
Mute This Topic: https://lists.cip-project.org/mt/77461654/4520388