Re: [cip-dev] [RFC PATCH 4.19.y-cip 28/50] PCI: endpoint: Add notification for core init completion

Lad Prabhakar
2020-10-21T20:16:37Z

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

Hi Pavel,

Thank you for the review.

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 21 October 2020 20:01
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Subject: Re: [RFC PATCH 4.19.y-cip 28/50] PCI: endpoint: Add notification for core init completion
>
> Hi!
>
> > From: Vidya Sagar <vidyas@nvidia.com>
> >
> > commit 0ef22dcf0c1871888c4c0ee46a9d9c494f2fe997 upstream.
> >
> > Add support to send notifications to EPF from EPC once the core
> > registers initialization is complete.
>
> >
> > +/**
> > + * pci_epc_init_notify() - Notify the EPF device that EPC device's core
> > + * initialization is completed.
> > + * @epc: the EPC device whose core initialization is completeds
> > + *
> > + * Invoke to Notify the EPF device that the EPC device's initialization
> > + * is completed.
> > + */
> > +void pci_epc_init_notify(struct pci_epc *epc)
> > +{
> > + if (!epc || IS_ERR(epc))
> > + return;
> > +
> > + atomic_notifier_call_chain(&epc->notifier, CORE_INIT, NULL);
> > +}
> > +EXPORT_SYMBOL_GPL(pci_epc_init_notify);
>
> Is this used somewhere? This adds symbol but noone calls this, and
> AFAICT it is not used in the rest of the series, either.
>
Yep none users (only dwc uses it mainline).

> We can merge it, anyway, I guess, but... explanation would be welcome.
>
Ill post it as part of non-RFC feel free to drop it.

Cheers,
Prabhakar

> Best regards,
> Pavel
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5636): https://lists.cip-project.org/g/cip-dev/message/5636
Mute This Topic: https://lists.cip-project.org/mt/77461704/4520388