Re: [cip-dev] [RFC PATCH 4.19.y-cip 28/50] PCI: endpoint: Add notification for core init completion

Pavel Machek
2020-10-21T19:01:07Z

[-- Attachment #1.1: Type: text/plain, Size: 1141 bytes --]

Hi!

> From: Vidya Sagar <vidyas@nvidia.com>
>
> commit 0ef22dcf0c1871888c4c0ee46a9d9c494f2fe997 upstream.
>
> Add support to send notifications to EPF from EPC once the core
> registers initialization is complete.

>
> +/**
> + * pci_epc_init_notify() - Notify the EPF device that EPC device's core
> + * initialization is completed.
> + * @epc: the EPC device whose core initialization is completeds
> + *
> + * Invoke to Notify the EPF device that the EPC device's initialization
> + * is completed.
> + */
> +void pci_epc_init_notify(struct pci_epc *epc)
> +{
> + if (!epc || IS_ERR(epc))
> + return;
> +
> + atomic_notifier_call_chain(&epc->notifier, CORE_INIT, NULL);
> +}
> +EXPORT_SYMBOL_GPL(pci_epc_init_notify);

Is this used somewhere? This adds symbol but noone calls this, and
AFAICT it is not used in the rest of the series, either.

We can merge it, anyway, I guess, but... explanation would be welcome.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5634): https://lists.cip-project.org/g/cip-dev/message/5634
Mute This Topic: https://lists.cip-project.org/mt/77461704/4520388