Re: [cip-dev] [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's

["Pavel Machek" <pavel@denx.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1735 bytes --]

Hi!

> This patch series adds SPI driver for the Renesas RPC-IF.
> Alongside relevant changes for spi-mem have been also
> backported. This enables accessing SPI flash chip connected
> to RPC-IF on RZ/G2x boards.
> 
> We currently only aim to backport just the driver hence there
> are no changes to dts/i files. The driver has been tested on
> RZ/G2{EM} with all the required dts/i changes [1].

Okay, that was quick.

What is your plan, merge dts changes soon? Or is the driver useful
even without the dts changes?

> Changes for v2:
> * Patches {1, 3, 4}/7 unchanged
> * Patch 2/7
>    * Fixed reference leak for OF node in rpcif_probe()
>    * Fixed overwriting return value in error path of rpcif_manual_xfer()
>    * Replaced C++ style comment with C style
>    * Replaced tab with a space between struct and struct name
>    * Fixed a typo in commit message (s/absract/abstract)
> * Patch 5/7
>    * Fixed reference leak in spi_mem_access_start for PM
> * Patch 6/7
>    * Return early in spi_mem_dirmap_dirmap_{read/write}
> * Patch 7/7
>    * Replaced C++ style comment with C style
>    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
>      CONFIG_PM_SLEEP ifdef checks
>    * Elaborated the description for SPI_RPCIF config
>    * Dropped the label err_put_ctlr from rpc_spi_probe()

Thanks for the changes; they are probably good (I have yet to take
close look), but I wonder if we should wait until they hit next or
mainline? If upstream maintainer disagrees, we would get divergence...

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5865): https://lists.cip-project.org/g/cip-dev/message/5865
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-