Re: [cip-dev] [PATCH v3 4.19.y-cip 08/17] spi: spi-mem: export spi_mem_default_supports_op()

["Pavel Machek" <pavel@denx.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1518 bytes --]

Hi!

> >> From: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> >  
> >> This patch also squashes upstream commit 72e6841608b9 ("spi: spi-mem: Fix
> >> build error without CONFIG_SPI_MEM")' in the current patch as commit
> >> 46109648052f ("spi: spi-mem: export spi_mem_default_supports_op()")'
> >> introduced below build error when built without CONFIG_SPI_MEM:
> > 
> > This puts function definition directly into header file; I don't think
> > that will work when multiple files include it.
> > 
> > Adding "static inline" is the usual solution for this.
> 
> Has been done upstream by b5881b153bc8 ("spi: spi-mem: Make
> spi_mem_default_supports_op() static inline")
> 
> I was once raising this concern internally that when commits are
> backported not all of them are backported but since I did not know
> enough about how CIP wants to do the backporting so never raised the
> issue. But this is an example what I was concerned about.

We can probably create a simple script that goes through commits,
collects their "upstream" commit ids, and searches linux-next for
Fixes: xxx... So we'd have simple way of checking if we are missing
any fixes.

If Renesas could submit b5881b153bc8 ("spi: spi-mem: Make 
spi_mem_default_supports_op() static inline") for 4.19-cip, it would
be nice :-).

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6043): https://lists.cip-project.org/g/cip-dev/message/6043
Mute This Topic: https://lists.cip-project.org/mt/79450068/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-