Re: [PATCH 5.10.y-cip] can: rcar_canfd: rcar_canfd_channel_probe(): make sure we free CAN network device

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1434 bytes --]

Hi!

> > make sure we free CAN network device
> > 
> > commit 72b1e360572f9fa7d08ee554f1da29abce23f288 upstream.
> > 
> > Make sure we free CAN network device in the error path. There are several
> > jumps to fail label after allocating the CAN network device successfully. This
> > patch places the free_candev() under fail label so that in failure path a jump to
> > fail label frees the CAN network device.
> > 
> > Fixes: 76e9353a80e9 ("can: rcar_canfd: Add support for RZ/G2L family")
> > Link:
> > https://lore.kernel.org/all/20220106114801.20563-1-prabhakar.mahadev-lad.r
> > j@bp.renesas.com
> > Reported-by: Pavel Machek <pavel@denx.de>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Kieran Bingham
> > <kieran.bingham+renesas@ideasonboard.com>
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  drivers/net/can/rcar/rcar_canfd.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> LGTM.
> If there is no other opinion, I can apply this.
>   Test:
> > https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/457123034

Looks good to me, go ahead :-).

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]