From: Pavel Machek <pavel@denx.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 5.10.y-cip 16/27] memory: renesas-rpc-if: Add support for RZ/G2L
Date: Tue, 1 Feb 2022 12:20:46 +0100 [thread overview]
Message-ID: <20220201112046.GE30077@amd> (raw)
In-Reply-To: <20220131121903.8620-17-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
Hi!
> commit b04cc0d912eb80d3c438b11d96ca847c3e77e8ab upstream.
>
> SPI Multi I/O Bus Controller on RZ/G2L SoC is almost identical to
> the RPC-IF interface found on R-Car Gen3 SoC's.
>
> This patch adds a new compatible string for the RZ/G2L family so
> that the timing values on RZ/G2L can be adjusted.
> index 367b0d72bf62..40bca89268c3 100644
> --- a/drivers/mtd/hyperbus/rpc-if.c
> +++ b/drivers/mtd/hyperbus/rpc-if.c
> @@ -132,7 +132,9 @@ static int rpcif_hb_probe(struct platform_device *pdev)
>
> rpcif_enable_rpm(&hyperbus->rpc);
>
> - rpcif_hw_init(&hyperbus->rpc, true);
> + error = rpcif_hw_init(&hyperbus->rpc, true);
> + if (error)
> + return error;
>
> hyperbus->hbdev.map.size = hyperbus->rpc.size;
> hyperbus->hbdev.map.virt = hyperbus->rpc.dirmap;
This needs to rpcif_disable_rpm() before returning, AFAICT.
> +++ b/drivers/spi/spi-rpc-if.c
> @@ -156,7 +156,9 @@ static int rpcif_spi_probe(struct platform_device *pdev)
> ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_TX_QUAD | SPI_RX_QUAD;
> ctlr->flags = SPI_CONTROLLER_HALF_DUPLEX;
>
> - rpcif_hw_init(rpc, false);
> + error = rpcif_hw_init(rpc, false);
> + if (error)
> + return error;
>
> error = spi_register_controller(ctlr);
> if (error) {
Same here.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2022-02-01 11:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 12:18 [PATCH 5.10.y-cip 00/27] Add RPCIF, SCI{F1} support to Renesas RZ/G2L SoC Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 01/27] dt-bindings: pincfg-node: Add "output-impedance-ohms" property Lad Prabhakar
2022-08-13 13:45 ` Pavel Machek
2022-08-14 21:37 ` Prabhakar Mahadev Lad
2022-01-31 12:18 ` [PATCH 5.10.y-cip 02/27] pinctrl: pinconf-generic: Add support for "output-impedance-ohms" to be extracted from DT files Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 03/27] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Add output-impedance-ohms property Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 04/27] pinctrl: renesas: rzg2l: Rename RZG2L_SINGLE_PIN_GET_PORT macro Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 05/27] pinctrl: renesas: rzg2l: Add helper functions to read/write pin config Lad Prabhakar
2022-02-01 11:05 ` Pavel Machek
2022-01-31 12:18 ` [PATCH 5.10.y-cip 06/27] pinctrl: renesas: rzg2l: Add support to get/set pin config for GPIO port pins Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 07/27] pinctrl: renesas: rzg2l: Rename PIN_CFG_* macros to match HW manual Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 08/27] pinctrl: renesas: rzg2l: Add support to get/set drive-strength and output-impedance-ohms Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 09/27] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 10/27] dt-bindings: memory: renesas,rpc-if: Add support for the R9A07G044 Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 11/27] dt-bindings: memory: renesas,rpc-if: Add optional interrupts property Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 12/27] mtd: hyperbus: rpc-if: Check return value of rpcif_sw_init() Lad Prabhakar
2022-02-01 3:08 ` nobuhiro1.iwamatsu
2022-01-31 12:18 ` [PATCH 5.10.y-cip 13/27] memory: renesas-rpc-if: Return error in case devm_ioremap_resource() fails Lad Prabhakar
2022-02-01 3:10 ` nobuhiro1.iwamatsu
2022-01-31 12:18 ` [PATCH 5.10.y-cip 14/27] memory: renesas-rpc-if: Drop usage of RPCIF_DIRMAP_SIZE macro Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 15/27] memory: renesas-rpc-if: correct whitespace Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 16/27] memory: renesas-rpc-if: Add support for RZ/G2L Lad Prabhakar
2022-02-01 11:08 ` Pavel Machek
2022-02-01 11:20 ` Pavel Machek [this message]
2022-01-31 12:18 ` [PATCH 5.10.y-cip 17/27] clk: renesas: r9a07g044: Add clock and reset entries for SPI Multi I/O Bus Controller Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 18/27] arm64: dts: renesas: r9a07g044: Add SPI Multi I/O Bus controller node Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 19/27] arm64: dts: renesas: rzg2l-smarc-som: Enable serial NOR flash Lad Prabhakar
2022-02-01 11:10 ` Pavel Machek
2022-01-31 12:18 ` [PATCH 5.10.y-cip 20/27] clk: renesas: r9a07g044: Add clock and reset entry for SCI1 Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 21/27] dt-bindings: serial: renesas,scif: Make resets as a required property Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 22/27] dt-bindings: serial: renesas,sci: Document RZ/G2L SoC Lad Prabhakar
2022-01-31 12:18 ` [PATCH 5.10.y-cip 23/27] serial: sh-sci: Add support to deassert/assert reset line Lad Prabhakar
2022-01-31 12:19 ` [PATCH 5.10.y-cip 24/27] arm64: dts: renesas: r9a07g044: Add SCIF[1-4] nodes Lad Prabhakar
2022-01-31 12:19 ` [PATCH 5.10.y-cip 25/27] arm64: dts: renesas: rzg2l-smarc: Enable SCIF2 on carrier board Lad Prabhakar
2022-02-01 11:11 ` Pavel Machek
2022-01-31 12:19 ` [PATCH 5.10.y-cip 26/27] arm64: dts: renesas: r9a07g044: Add SCI[0-1] nodes Lad Prabhakar
2022-01-31 12:19 ` [PATCH 5.10.y-cip 27/27] arm64: dts: renesas: r9a07g044: Sort psci node Lad Prabhakar
2022-02-01 11:22 ` [PATCH 5.10.y-cip 00/27] Add RPCIF, SCI{F1} support to Renesas RZ/G2L SoC Pavel Machek
2022-02-01 18:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201112046.GE30077@amd \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox