Hi! > commit b04cc0d912eb80d3c438b11d96ca847c3e77e8ab upstream. > > SPI Multi I/O Bus Controller on RZ/G2L SoC is almost identical to > the RPC-IF interface found on R-Car Gen3 SoC's. > > This patch adds a new compatible string for the RZ/G2L family so > that the timing values on RZ/G2L can be adjusted. > index 367b0d72bf62..40bca89268c3 100644 > --- a/drivers/mtd/hyperbus/rpc-if.c > +++ b/drivers/mtd/hyperbus/rpc-if.c > @@ -132,7 +132,9 @@ static int rpcif_hb_probe(struct platform_device *pdev) > > rpcif_enable_rpm(&hyperbus->rpc); > > - rpcif_hw_init(&hyperbus->rpc, true); > + error = rpcif_hw_init(&hyperbus->rpc, true); > + if (error) > + return error; > > hyperbus->hbdev.map.size = hyperbus->rpc.size; > hyperbus->hbdev.map.virt = hyperbus->rpc.dirmap; This needs to rpcif_disable_rpm() before returning, AFAICT. > +++ b/drivers/spi/spi-rpc-if.c > @@ -156,7 +156,9 @@ static int rpcif_spi_probe(struct platform_device *pdev) > ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_TX_QUAD | SPI_RX_QUAD; > ctlr->flags = SPI_CONTROLLER_HALF_DUPLEX; > > - rpcif_hw_init(rpc, false); > + error = rpcif_hw_init(rpc, false); > + if (error) > + return error; > > error = spi_register_controller(ctlr); > if (error) { Same here. Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany