From: Pavel Machek <pavel@denx.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Chris Paterson <chris.paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH RESEND 5.10.y-cip 01/13] kernel.h: split out mathematical helpers
Date: Sat, 16 Jul 2022 11:08:39 +0200 [thread overview]
Message-ID: <20220716090839.GA5658@duo.ucw.cz> (raw)
In-Reply-To: <20220715073916.2321319-2-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]
Hi!
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> commit aa6159ab99a9ab5df835b4750b66cf132a5aa292 upstream
>
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out
> mathematical helpers.
>
> At the same time convert users in header and lib folder to use new
> header. Though for time being include new header back to kernel.h to
> avoid twisted indirected includes for existing users.
This is rather intrusive for two lines which we really need, and may
cause rejects in future.
I'd suggest identifying the defines needed by the driver, and just
adding those. kernel.h would be acceptable. Or you can add math.h with
just defines needed, but please avoid code movement.
Best regards,
Pavel
> ---
> fs/nfs/callback_proc.c | 5 +
> include/linux/bitops.h | 11 ++-
> include/linux/dcache.h | 1 +
> include/linux/iommu-helper.h | 4 +-
> include/linux/kernel.h | 173 +--------------------------------
> include/linux/math.h | 177 ++++++++++++++++++++++++++++++++++
> include/linux/rcu_node_tree.h | 2 +
> include/linux/units.h | 2 +-
> lib/errname.c | 1 +
> lib/errseq.c | 1 +
> lib/find_bit.c | 3 +-
> lib/math/div64.c | 4 +-
> lib/math/int_pow.c | 2 +-
> lib/math/int_sqrt.c | 3 +-
> lib/math/reciprocal_div.c | 9 +-
> 15 files changed, 215 insertions(+), 183 deletions(-)
> create mode 100644 include/linux/math.h
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-07-16 9:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 7:39 [PATCH RESEND 5.10.y-cip 00/13] Add thermal driver and watchdog driver enhancements Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 01/13] kernel.h: split out mathematical helpers Biju Das
2022-07-16 9:08 ` Pavel Machek [this message]
2022-07-16 14:16 ` Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 02/13] units: Add SI metric prefix definitions Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 03/13] thermal/drivers: Add TSU driver for RZ/G2L Biju Das
2022-07-16 10:53 ` [cip-dev] " Pavel Machek
2022-07-16 14:36 ` Biju Das
2022-07-18 5:44 ` Biju Das
2022-07-18 8:55 ` Pavel Machek
2022-07-18 9:01 ` Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 04/13] thermal/drivers/rz2gl: Add error check for reset_control_deassert() Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 05/13] thermal/drivers/rz2gl: Fix OTP Calibration Register values Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 06/13] arm64: defconfig: Enable additional support for Renesas platforms Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 07/13] watchdog: rzg2l_wdt: Fix 32bit overflow issue Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 08/13] watchdog: rzg2l_wdt: Fix Runtime PM usage Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 09/13] watchdog: rzg2l_wdt: Fix 'BUG: Invalid wait context' Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 10/13] watchdog: rzg2l_wdt: Fix reset control imbalance Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 11/13] watchdog: rzg2l_wdt: Add error check for reset_control_deassert Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 12/13] watchdog: rzg2l_wdt: Use force reset for WDT reset Biju Das
2022-07-15 7:39 ` [PATCH RESEND 5.10.y-cip 13/13] watchdog: rzg2l_wdt: Add set_timeout callback Biju Das
2022-07-16 11:13 ` Pavel Machek
2022-07-16 14:24 ` Biju Das
2022-07-15 7:46 ` [PATCH RESEND 5.10.y-cip 00/13] Add thermal driver and watchdog driver enhancements Biju Das
2022-07-15 9:28 ` nobuhiro1.iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220716090839.GA5658@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.paterson2@renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox