From: uli@kernel.org
To: cip-dev@lists.cip-project.org, ahoemig@datus.com
Cc: Ulrich Hecht <uli@kernel.org>
Subject: [PATCH] Revert "md: fix a crash in mempool_free"
Date: Fri, 22 Dec 2023 02:36:24 +0100 [thread overview]
Message-ID: <20231222013624.1814544-1-uli@kernel.org> (raw)
From: Ulrich Hecht <uli@kernel.org>
This reverts commit a8e2077ebc799a5fc55c369d4a4e41ba05534fb6, which is
commit cf06b162f5b6337b688072a1a47941280b8f7110 upstream.
The patch has been applied twice:
779785788a82f md: fix a crash in mempool_free
a8e2077ebc799 md: fix a crash in mempool_free
This reverts the second variant which has been mangled and causes a crash
when using raid1.
Reported-by: Alexander Hömig <ahoemig@datus.com>
Fixes: a8e2077ebc79 ("md: fix a crash in mempool_free")
Signed-off-by: Ulrich Hecht <uli@kernel.org>
---
Alexander, could you do us the favor of testing this again to make sure that
the removal of the rdev_dec_pending() call doesn't cause any issues? Thanks.
CU
Uli
drivers/md/md.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 09e1b21460470..67bfdd95e9d4a 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -736,10 +736,6 @@ static void super_written(struct bio *bio)
bio_put(bio);
- bio_put(bio);
-
- rdev_dec_pending(rdev, mddev);
-
if (atomic_dec_and_test(&mddev->pending_writes))
wake_up(&mddev->sb_wait);
}
--
2.39.2
reply other threads:[~2023-12-22 2:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222013624.1814544-1-uli@kernel.org \
--to=uli@kernel.org \
--cc=ahoemig@datus.com \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox