* [PATCH] Revert "md: fix a crash in mempool_free"
@ 2023-12-22 1:36 uli
0 siblings, 0 replies; only message in thread
From: uli @ 2023-12-22 1:36 UTC (permalink / raw)
To: cip-dev, ahoemig; +Cc: Ulrich Hecht
From: Ulrich Hecht <uli@kernel.org>
This reverts commit a8e2077ebc799a5fc55c369d4a4e41ba05534fb6, which is
commit cf06b162f5b6337b688072a1a47941280b8f7110 upstream.
The patch has been applied twice:
779785788a82f md: fix a crash in mempool_free
a8e2077ebc799 md: fix a crash in mempool_free
This reverts the second variant which has been mangled and causes a crash
when using raid1.
Reported-by: Alexander Hömig <ahoemig@datus.com>
Fixes: a8e2077ebc79 ("md: fix a crash in mempool_free")
Signed-off-by: Ulrich Hecht <uli@kernel.org>
---
Alexander, could you do us the favor of testing this again to make sure that
the removal of the rdev_dec_pending() call doesn't cause any issues? Thanks.
CU
Uli
drivers/md/md.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 09e1b21460470..67bfdd95e9d4a 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -736,10 +736,6 @@ static void super_written(struct bio *bio)
bio_put(bio);
- bio_put(bio);
-
- rdev_dec_pending(rdev, mddev);
-
if (atomic_dec_and_test(&mddev->pending_writes))
wake_up(&mddev->sb_wait);
}
--
2.39.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-22 2:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-22 1:36 [PATCH] Revert "md: fix a crash in mempool_free" uli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox