public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: Ulrich Hecht <uli@fpond.eu>
To: Alexander Grund <theflamefire89@gmail.com>,
	cip-dev@lists.cip-project.org
Subject: Re: [PATCH 4.4] bonding: Break instead of returning in alb_send_learning_packets
Date: Thu, 4 Apr 2024 14:46:29 +0200 (CEST)	[thread overview]
Message-ID: <28983187.1206355.1712234789231@webmail.strato.com> (raw)
In-Reply-To: <20240323124301.250422-1-theflamefire89@gmail.com>


> On 03/23/2024 1:43 PM CET Alexander Grund <theflamefire89@gmail.com> wrote:
> 
>  
> From: Alexander Grund <flamefire89@gmail.com>
> 
> The upstream commit used a function which upon returning an error value
> would break out of the surrounding loop.
> In 4.4.x the loop is inside the function alb_send_learning_packets
> hence returning would be wrong as it will skip the rcu_read_unlock.
> Moreover returning a value from a void function doesn't even compile.
> 
> Fixes d6b83f1e (bonding: return -ENOMEM instead of BUG in alb_upper_dev_walk)
> 
> Signed-off-by: Alexander Grund <flamefire89@gmail.com>

Thanks, applied.

CU
Uli


      reply	other threads:[~2024-04-04 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23 12:43 [PATCH 4.4] bonding: Break instead of returning in alb_send_learning_packets Alexander Grund
2024-04-04 12:46 ` Ulrich Hecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28983187.1206355.1712234789231@webmail.strato.com \
    --to=uli@fpond.eu \
    --cc=cip-dev@lists.cip-project.org \
    --cc=theflamefire89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox