From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20022C433EF for ; Mon, 14 Feb 2022 16:19:27 +0000 (UTC) Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net [185.136.65.225]) by mx.groups.io with SMTP id smtpd.web09.36393.1644855565363579185 for ; Mon, 14 Feb 2022 08:19:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=quirin.gylstorff@siemens.com header.s=fm1 header.b=U60v2DFj; spf=pass (domain: rts-flowmailer.siemens.com, ip: 185.136.65.225, mailfrom: fm-51332-2022021416192285d7e41e2503c7c11d-alpixd@rts-flowmailer.siemens.com) Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 2022021416192285d7e41e2503c7c11d for ; Mon, 14 Feb 2022 17:19:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=quirin.gylstorff@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:References:In-Reply-To; bh=+11zXdGfyhYFhenT9sWRWtSYfRLqwsaIF5VPAn/Hx5E=; b=U60v2DFjUcMLT578xZFtw2iYEAWcXzeLSddjQt0RklVk37swUD9lgH6h1mxI8yfuDAEaEZ nv0j8QPyfZprhopjrNEuw9CxbMOOWQjRF1Oi75KeKoQVsjk51Po4rXbnF9yDsXCDDXbSxvVe a6vsa7hZho9X7Jaw2mFEkyDGip1bM=; Message-ID: <30ccc30f-e12a-5762-a27d-e44656c8d896@siemens.com> Date: Mon, 14 Feb 2022 17:19:21 +0100 MIME-Version: 1.0 Subject: Re: [cip-dev] [isar-cip-core][PATCH 1/1] Deploy efibootguardx64.efi and bg_setenv from .deb package Content-Language: en-US To: cip-dev@lists.cip-project.org, ubely@ilbers.de References: <20220214094237.16369-1-ubely@ilbers.de> <20220214094237.16369-2-ubely@ilbers.de> From: quirin.gylstorff@siemens.com Organization: Siemens In-Reply-To: <20220214094237.16369-2-ubely@ilbers.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-51332:519-21489:flowmailer List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 14 Feb 2022 16:19:27 -0000 X-Groupsio-URL: https://lists.cip-project.org/g/cip-dev/message/7597 On 2/14/22 10:42, Uladzimir Bely via lists.cip-project.org wrote: > This patch makes efibootguardx64.efi binary to be included in .deb package. > Also, files are now deployed from .deb package, not from ${S} directory. > > Signed-off-by: Uladzimir Bely > --- > recipes-bsp/efibootguard/efibootguard_0.9-git+isar.bb | 10 ++++++++-- > .../efibootguard/files/debian/efibootguard.install | 1 + > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/recipes-bsp/efibootguard/efibootguard_0.9-git+isar.bb b/recipes-bsp/efibootguard/efibootguard_0.9-git+isar.bb > index 2817e5b..2028ac6 100644 > --- a/recipes-bsp/efibootguard/efibootguard_0.9-git+isar.bb > +++ b/recipes-bsp/efibootguard/efibootguard_0.9-git+isar.bb > @@ -41,6 +41,12 @@ do_prepare_build() { > > dpkg_runbuild_append() { > install -m 0755 -d ${DEPLOY_DIR_IMAGE} > - install -m 0755 ${S}/efibootguardx64.efi ${DEPLOY_DIR_IMAGE}/bootx64.efi > - install -m 0755 ${S}/bg_setenv ${DEPLOY_DIR_IMAGE}/bg_setenv > + dpkg --fsys-tarfile ${WORKDIR}/${PN}_${PV}_${DISTRO_ARCH}.deb | \ > + tar xOf - ./usr/lib/efibootguardx64.efi \ > + > ${DEPLOY_DIR_IMAGE}/bootx64.efi > + chmod 755 ${DEPLOY_DIR_IMAGE}/bootx64.efi > + dpkg --fsys-tarfile ${WORKDIR}/${PN}_${PV}_${DISTRO_ARCH}.deb | \ > + tar xOf - ./usr/bin/bg_setenv \ > + > ${DEPLOY_DIR_IMAGE}/bg_setenv > + chmod 755 ${DEPLOY_DIR_IMAGE}/bg_setenv > } This only works if sstate is disabled. As the current sstate implementation does not execute any function if a package is already available. If sstate is enabled the following error occurs: ``` ERROR: cip-core-image-1.0-r0 do_wic_image: Error executing a python function in exec_python_func() autogenerated: ``` I will send a fix to the list. Quirin > diff --git a/recipes-bsp/efibootguard/files/debian/efibootguard.install b/recipes-bsp/efibootguard/files/debian/efibootguard.install > index 8a8d9d3..d0c3ee3 100644 > --- a/recipes-bsp/efibootguard/files/debian/efibootguard.install > +++ b/recipes-bsp/efibootguard/files/debian/efibootguard.install > @@ -1,2 +1,3 @@ > bg_setenv usr/bin > bg_printenv usr/bin > +efibootguardx64.efi usr/lib > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#7593): https://lists.cip-project.org/g/cip-dev/message/7593 > Mute This Topic: https://lists.cip-project.org/mt/89132786/1753640 > Group Owner: cip-dev+owner@lists.cip-project.org > Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129121/1753640/1405269326/xyzzy [quirin.gylstorff@siemens.com] > -=-=-=-=-=-=-=-=-=-=-=- >