From: Ulrich Hecht <uli@fpond.eu>
To: pavel@nabladev.com
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
"nobuhiro.iwamatsu.x90@mail.toshiba"
<nobuhiro.iwamatsu.x90@mail.toshiba>
Subject: Re: [cip-dev] Request for review for 4.19-st20, 4.19-cip136
Date: Fri, 11 Sep 2026 12:15:20 +0200 (CEST) [thread overview]
Message-ID: <315575947.88377.1789121720672@webmail.strato.de> (raw)
In-Reply-To: <aqMF3bvKF4A-mzbV@duo.ucw.cz>
> On 09/10/2026 9:32 PM CEST Pavel Machek via lists.cip-project.org <pavel=nabladev.com@lists.cip-project.org> wrote:
> Reviewed-by: Pavel Machek <pavel@nabladev.com>
Thanks again.
> Most of the patches look good to me, some questions are below.
>
> Thanks and sorry that it took so long.
It was a lot...
> I guess I'm confused here. This one is not correct on its own, as it
> creates non-balanced situation. Is the 1c72d53630aa3 fixing it up?
> Where does 1c72d53630aa3 come from? Will it cause bisect problems?
>
> !! > 1c72d53630aa3 NFS: Pin the 'struct nfs_server' during a FREE_STATEID call
>
> This one does not have "upstream commit" annotation, and I could not
> find where it comes from. I checked 6.12-cip version, and it looks
> very different from this.
According to my notes the chain of bugs is as follows:
- "nfs4: take a reference on the nfs_client when running FREE_STATEID" is broken.
- It is fixed by "NFS: Decrement refcounts if allocating nfs_free_stateid_data fails" (which I have cherry-picked from mainline and forgot to annotate).
- The latter contains parts of the 5.10 version of "NFS: Pin the 'struct nfs_server' during a FREE_STATEID call" which are therefore omitted in the backport.
> !! no upstream annotation > f1f7d30dcdfaa NFS: Decrement refcounts if allocating nfs_free_stateid_data fails
Fixed.
CU
Uli
prev parent reply other threads:[~2026-09-11 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 18:32 Request for review for 4.19-st20, 4.19-cip136 Ulrich Hecht
2026-09-03 9:00 ` Pavel Machek
2026-09-03 9:18 ` Ulrich Hecht
2026-09-03 11:59 ` Pavel Machek
2026-09-10 8:09 ` [cip-dev] " Ulrich Hecht
2026-09-07 11:04 ` Pavel Machek
2026-09-10 8:09 ` [cip-dev] " Ulrich Hecht
2026-09-09 19:23 ` Pavel Machek
2026-09-10 19:32 ` Pavel Machek
2026-09-11 10:15 ` Ulrich Hecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=315575947.88377.1789121720672@webmail.strato.de \
--to=uli@fpond.eu \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=pavel@nabladev.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox