Re: [isar-cip-core][PATCH 1/7] add recipe for optee qemu arm64

[Jan Kiszka <jan.kiszka@siemens.com>]

On 19.10.22 15:21, Schultschik, Sven (DI PA DCP R&D 2) wrote:
> 
> 
>> -----Ursprüngliche Nachricht-----
>> Von: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>
>> Gesendet: Mittwoch, 19. Oktober 2022 12:44
>> An: Schultschik, Sven (DI PA DCP R&D 2) <sven.schultschik@siemens.com>;
> cip-
>> dev@lists.cip-project.org
>> Betreff: Re: [isar-cip-core][PATCH 1/7] add recipe for optee qemu arm64
>>
>> On 19.10.22 11:21, sven.schultschik@siemens.com wrote:
>>> From: Sven Schultschik <sven.schultschik@siemens.com>
>>>
>>> The recipe provides the possibility to create optee-os binaries for
>>> use inside of an qemu secureboot setup with edk2, rpmb, u-boot and
>>> uefi
>>>
>>> Signed-off-by: Sven Schultschik <sven.schultschik@siemens.com>
>>> ---
>>>  .../op-tee/optee-os-qemu-arm64_3.17.0.bb      | 57 +++++++++++++++++++
>>>  recipes-bsp/u-boot/files/secure-boot.cfg.tmpl |  7 +++
>>>  recipes-bsp/u-boot/u-boot-common.inc          |  6 +-
>>>  3 files changed, 67 insertions(+), 3 deletions(-)  create mode 100644
>>> recipes-bsp/op-tee/optee-os-qemu-arm64_3.17.0.bb
>>>
>>> diff --git a/recipes-bsp/op-tee/optee-os-qemu-arm64_3.17.0.bb
>>> b/recipes-bsp/op-tee/optee-os-qemu-arm64_3.17.0.bb
>>> new file mode 100644
>>> index 000000000..5e60041af
>>> --- /dev/null
>>> +++ b/recipes-bsp/op-tee/optee-os-qemu-arm64_3.17.0.bb
>>> @@ -0,0 +1,57 @@
>>> +#
>>> +# CIP Core, generic profile
>>> +#
>>> +# Copyright (c) Siemens AG, 2022
>>> +#
>>> +# Authors:
>>> +#  Sven Schultschik <sven.schultschik@siemens.com> # #
>>> +SPDX-License-Identifier: MIT #
>>> +
>>> +HOMEPAGE =
>>
> "https://github.c
>> om%2FOP-
>> TEE%2Foptee_os&amp;data=05%7C01%7Csven.schultschik%40siemens.com%7
>> C4f98c0d0333a4da5414a08dab1bee02e%7C38ae3bcd95794fd4addab42e1495d
>> 55a%7C1%7C0%7C638017730602326587%7CUnknown%7CTWFpbGZsb3d8eyJ
>> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
>> 3000%7C%7C%7C&amp;sdata=EnwEqlIP690Rw3fcrJv0Wc9dfcAc%2BN8h4O%2B
>> yRdvsXX4%3D&amp;reserved=0"
>>> +MAINTAINER = "Sven Schultschik <sven.schultschik@siemens.com>"
>>> +LICENSE = "BSD-2-Clause"
>>> +
>>> +require recipes-bsp/optee-os/optee-os-custom.inc
>>> +
>>> +SRC_URI += " \
>>> +            gitsm://github.com/OP-
>> TEE/optee_os.git;branch=master;protocol=https;destsuffix=git;rev=${PV}"
>>
>> Do we really need the second-class supported gitsm fetcher here? Also,
>> destsuffix and rev are both redundant (they are defaults).
> 
> I tried your suggestion and removed destsuffix and rev and now I remember
> why I added it initially:
> 
> SRC_URI += " \
>     git://github.com/OP-TEE/optee_os.git;branch=master;protocol=https"
> 
> optee-os-qemu-arm64-3.17.0-r0 do_fetch: Fetcher failure for URL:
> 'git://github.com/OP-TEE/optee_os.git;branch=master;protocol=https'. Please
> set a valid SRCREV for url ['SRCREV_default_pn-optee-os-qemu-arm64',
> 'SRCREV_default', 'SRCREV_pn-optee-os-qemu-arm64', 'SRCREV'] (possible key
> names are git://github.com/OP-TEE/optee_os.git;branch=master;protocol=https,
> or use a ;rev=X URL parameter)

Right, it gives you an even better suggestion than I what to do /wrt
SRCREV when you have multiple repos (not here but in edk2).

-- 
Siemens AG, Technology
Competence Center Embedded Linux