Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

[Ulrich Hecht]

Hi!

Here are the manual backports for the upcoming 4.4-st39, 4.4-cip74 and 4.4-cip74-rt43 releases that should be reviewed, and that can currently be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc

Trivial backports:

** m | d2d3052d9 6f8ecb o+ | gpio: vf610: connect GPIO label to dev name
** m | c075aa346 5d5aa2 o  | ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy
** m | 09fa241bc 4971c2 o+ | ima: Align ima_file_mmap() parameters with mmap_file LSM hook
** m | 38345d84e aa56b9 o  | dm flakey: fix logic when corrupting a bio
** m | c214be981 709fca o  | Bluetooth: hci_sock: purge socket queues in the destruct() callback
** m | 9acadaf26 a98fc2    | staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script
** m | 1c4293ded fe413a    | staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh
** m | 85f922f42 c22c3b o+ | net: phy: smsc: bail out in lan87xx_read_status if genphy_read_status fails

Not completely trivial backports, and/or stuff that touches important subsystems:

** m | 4e3b4b170 9a5571 o+ | f2fs: fix information leak in f2fs_move_inline_dirents()
** m | 5621f7a81 256fe4 o  | udf: Do not update file length for failed writes to inline files
** m | 11790a4fa b06730 o+ | irqdomain: Fix association race
** m | 30b560087 3f883c o+ | irqdomain: Fix disassociation race
** m | b40d2fbf4 4d57a7 o+ | ubi: ubi_wl_put_peb: Fix infinite loop when wear-leveling work failed
** m | 3df6f492f db4df8 o  | tty: fix out-of-bounds access in tty_driver_lookup_tty()
** m | 438d62a68 c4c81d o  | tty: serial: fsl_lpuart: disable the CTS when send break signal

I would also like an opinion or two on the importance of this patch:

** i | d5cf15857 e88b2c o+ | bpf: Fix 32 bit src register truncation on div/mod

I have chosen not to include it because it would require backporting quite a bit of infrastructure. According to the bug report at https://bugzilla.redhat.com/show_bug.cgi?id=1981954, the issue is not exploitable for out-of-bounds accesses on 4.4.

Thanks!

CU
Uli

Re: Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 2621 bytes --]

Hi!

> Here are the manual backports for the upcoming 4.4-st39, 4.4-cip74 and 4.4-cip74-rt43 releases that should be reviewed, and that can currently be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
> 
> Trivial backports:

a | d2d3052d9 6f8ecb o+ | gpio: vf610: connect GPIO label to dev name
a | 09fa241bc 4971c2 o+ | ima: Align ima_file_mmap() parameters with mmap_file LSM hook
a | 38345d84e aa56b9 o  | dm flakey: fix logic when corrupting a bio
a | c214be981 709fca o  | Bluetooth: hci_sock: purge socket queues in
a | 85f922f42 c22c3b o+ | net: phy: smsc: bail out in

These look good.

 | c075aa346 5d5aa2 o  | ARM: dts: exynos: Use Exynos5420

This one is wrong. Old compatible is used in
drivers/phy/phy-exynos-mipi-video.c . Suggested new compatible is not
used anywhere, so this would break things.

 | 9acadaf26 a98fc2    | staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script
 | 1c4293ded fe413a    | staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh

I'd not bother with staging stuff. Plus, these are not really
bugfixes, they are really cleanups. I'd suggest we drop these.

> Not completely trivial backports, and/or stuff that touches important subsystems:
> 
a | 4e3b4b170 9a5571 o+ | f2fs: fix information leak in f2fs_move_inline_dirents()
a | 5621f7a81 256fe4 o  | udf: Do not update file length for failed writes to inline files
I assume this is preparation for next patch? | 11790a4fa b06730 o+ | irqdomain: Fix association race
a | 30b560087 3f883c o+ | irqdomain: Fix disassociation race
a | b40d2fbf4 4d57a7 o+ | ubi: ubi_wl_put_peb: Fix infinite loop when wear-leveling work failed
a | 3df6f492f db4df8 o  | tty: fix out-of-bounds access in tty_driver_lookup_tty()
a | 438d62a68 c4c81d o  | tty: serial: fsl_lpuart: disable the CTS when send break signal

> I would also like an opinion or two on the importance of this patch:
> 
> ** i | d5cf15857 e88b2c o+ | bpf: Fix 32 bit src register truncation on div/mod
> 
> I have chosen not to include it because it would require backporting quite a bit of infrastructure. According to the bug report at https://bugzilla.redhat.com/show_bug.cgi?id=1981954, the issue is not exploitable for out-of-bounds accesses on 4.4.
>

I agree with not including this one. It backport would be tricky, and
testing it would be even trickier.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

[Ulrich Hecht]

Thanks for the reviews!

> On 03/30/2023 1:32 PM CEST Pavel Machek <pavel@denx.de> wrote:
>  | c075aa346 5d5aa2 o  | ARM: dts: exynos: Use Exynos5420
> 
> This one is wrong. Old compatible is used in
> drivers/phy/phy-exynos-mipi-video.c . Suggested new compatible is not
> used anywhere, so this would break things.
> 
>  | 9acadaf26 a98fc2    | staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script
>  | 1c4293ded fe413a    | staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh
> 
> I'd not bother with staging stuff. Plus, these are not really
> bugfixes, they are really cleanups. I'd suggest we drop these.

I'll drop all of those then.

> > Not completely trivial backports, and/or stuff that touches important subsystems:
> > 
> a | 4e3b4b170 9a5571 o+ | f2fs: fix information leak in f2fs_move_inline_dirents()
> a | 5621f7a81 256fe4 o  | udf: Do not update file length for failed writes to inline files
> I assume this is preparation for next patch? | 11790a4fa b06730 o+ | irqdomain: Fix association race

It's also a fix for a tiny bug in its own right.

> a | 30b560087 3f883c o+ | irqdomain: Fix disassociation race

CU
Uli

Re: Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

[Alexander Grund]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Any chance to get the patch series mentioned in https://lists.cip-project.org/g/cip-dev/message/11116 into the next release? They fix a deadlock, a regression from -st37 to -st38.

[-- Attachment #2: Type: text/html, Size: 280 bytes --]

Re: [cip-dev] Request for reviews for 4.4-st39, 4.4-cip74, 4.4-cip74-rt43

[Ulrich Hecht]

> On 03/31/2023 5:55 PM CEST Alexander Grund <theflamefire89@gmail.com> wrote:
> Any chance to get the patch series mentioned in https://lists.cip-project.org/g/cip-dev/message/11116 into the next release? They fix a deadlock, a regression from -st37 to -st38. 

Absolutely, I just missed it because of a deficiency in my e-mail filtering setup.
Thank you for your contribution.

CU
Uli