From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: nobuhiro.iwamatsu.x90@mail.toshiba, cip-dev@lists.cip-project.org
Cc: pavel@nabladev.com, uli@fpond.eu, john.madieu.xa@bp.renesas.com,
biju.das.jz@bp.renesas.com
Subject: Re: [cip-dev] [PATCH 6.1.y-cip 2/3] PCI: rzg3s-host: Remove duplicate field_get()
Date: Wed, 14 Oct 2026 18:20:32 +0300 [thread overview]
Message-ID: <6f97fc22-6107-4bc5-8d0d-508bb3ec78e6@tuxon.dev> (raw)
In-Reply-To: <1791930919-10628-3-git-send-email-nobuhiro.iwamatsu.x90@mail.toshiba>
On 10/14/26 01:35, Nobuhiro Iwamatsu via lists.cip-project.org wrote:
> The LTS commit 94cad2c26306 ("bitfield: Add non-constant field_{prep,get}()
> helpers") causes a duplicate definition of field_get().
> This removes field_get() from pcie-rzg3s-host.c, where the modification
> was made.
>
> ```
> drivers/pci/controller/pcie-rzg3s-host.c:181:9: error: ‘field_prep’ redefined [-Werror]
> 181 | #define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
> | ^~~~~~~~~~
> In file included from drivers/pci/controller/pcie-rzg3s-host.c:12:
> ./include/linux/bitfield.h:277:9: note: this is the location of the previous definition
> 277 | #define field_prep(mask, val) \
> | ^~~~~~~~~~
> ```
>
> Fixes: d71d7aba7486 ("PCI: rzg3s-host: Revert generic field helpers, use a local field_prep()")
> Cc: John Madieu<john.madieu.xa@bp.renesas.com>
> Signed-off-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.x90@mail.toshiba>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
next prev parent reply other threads:[~2026-10-14 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 22:35 [PATCH 6.1.y-cip 0/3] Remove duplicate field_get() Nobuhiro Iwamatsu
2026-10-13 22:35 ` [PATCH 6.1.y-cip 1/3] irqchip/renesas-rzv2h: " Nobuhiro Iwamatsu
2026-10-14 15:20 ` [cip-dev] " claudiu beznea
2026-10-13 22:35 ` [PATCH 6.1.y-cip 2/3] PCI: rzg3s-host: " Nobuhiro Iwamatsu
2026-10-14 15:20 ` claudiu beznea [this message]
2026-10-13 22:35 ` [PATCH 6.1.y-cip 3/3] soc: renesas: rz-sysc: Convert to common field_get() helper Nobuhiro Iwamatsu
2026-10-14 15:21 ` [cip-dev] " claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f97fc22-6107-4bc5-8d0d-508bb3ec78e6@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=john.madieu.xa@bp.renesas.com \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=pavel@nabladev.com \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox