Re: [cip-dev] [PATCH 5.10.y-cip 2/2] mmc: renesas_sdhi: Add suspend/resume hooks

[Claudiu Beznea <claudiu.beznea@tuxon.dev>]

Hi,

On 1/26/26 11:43, claudiu beznea via lists.cip-project.org wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> commit dcbce328d3a2d87770133834210cf328c083d480 upstream.
> 
> Add suspend/resume hooks which assert/deassert the reset signals, along
> with forcing runtime suspend/resume. This allows using the driver in
> scenarios where the resume is done with the help of bootloader and the
> bootloader disables the SDHI clocks, resets, IRQs before passing execution
> to Linux.
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> [claudiu.beznea: adjusted as follows:
> - in renesas_sdhi.h: kept the include section as it was in CIP v5.10, kept
>   the renesas_sdhi_probe() and renesas_sdhi_remove() prototype as it was on
>   v5.10 CIP
> - in renesas_sdhi_core.c: kept the renesas_sdhi_suspend() and
>   renesas_sdhi_remove() definitions
> - in renesas_sdhi_internal_dmac.c: kept the code from CIP v5.10
> - guard new PM function with CONFIG_PM]

This should have been CONFIG_PM_SLEEP as SET_SYSTEM_SLEEP_PM_OPS() is
defined as follows on v5.10:

#ifdef CONFIG_PM_SLEEP

#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \

        .suspend = suspend_fn, \

        .resume = resume_fn, \

        .freeze = suspend_fn, \

        .thaw = resume_fn, \

        .poweroff = suspend_fn, \

        .restore = resume_fn,

#else

#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)

#endif

I'll post v2 for this backport.

Thank you,
Claudiu