public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
* [isar-cip-core][PATCH] initramfs-overlay-hook: Fix copy_exec input
@ 2024-12-08 12:52 Jan Kiszka
  2024-12-12  7:44 ` d.kauschke154
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2024-12-08 12:52 UTC (permalink / raw)
  To: cip-dev

From: Jan Kiszka <jan.kiszka@siemens.com>

This variable name confusion caused breakages when using the hook in an
initramfs where no one else provided the dependencies, e.g. when
initramfs-crypt-hook was not used.

Fixes: 35a226b87671 ("initramfs-overlay-hook: Convert to hook.inc")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .../initramfs-overlay-hook/initramfs-overlay-hook_0.2.bb        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-initramfs/initramfs-overlay-hook/initramfs-overlay-hook_0.2.bb b/recipes-initramfs/initramfs-overlay-hook/initramfs-overlay-hook_0.2.bb
index a9e4ca21..56ae8d27 100644
--- a/recipes-initramfs/initramfs-overlay-hook/initramfs-overlay-hook_0.2.bb
+++ b/recipes-initramfs/initramfs-overlay-hook/initramfs-overlay-hook_0.2.bb
@@ -43,7 +43,7 @@ TEMPLATE_VARS += " INITRAMFS_OVERLAY_STORAGE_PATH \
 DEBIAN_DEPENDS .= ", awk, coreutils, util-linux"
 
 HOOK_ADD_MODULES = "overlay"
-HOOK_ADD_EXECS = "mountpoint awk e2fsck mke2fs"
+HOOK_COPY_EXECS = "mountpoint awk e2fsck mke2fs"
 
 do_install:append() {
     install -m 0755 "${WORKDIR}/${INITRAMFS_OVERLAY_RECOVERY_SCRIPT}" \
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [isar-cip-core][PATCH] initramfs-overlay-hook: Fix copy_exec input
  2024-12-08 12:52 [isar-cip-core][PATCH] initramfs-overlay-hook: Fix copy_exec input Jan Kiszka
@ 2024-12-12  7:44 ` d.kauschke154
  0 siblings, 0 replies; 2+ messages in thread
From: d.kauschke154 @ 2024-12-12  7:44 UTC (permalink / raw)
  To: cip-dev

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

Hi Jan,
I encountered the same issue with the initramfs-overlay-hook.
I tested your patch successfully on the qemu-arm64 machine.

Thanks for the fix!

David

[-- Attachment #2: Type: text/html, Size: 262 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-12  7:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-08 12:52 [isar-cip-core][PATCH] initramfs-overlay-hook: Fix copy_exec input Jan Kiszka
2024-12-12  7:44 ` d.kauschke154

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox