From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: ovidiu.panait.rb@renesas.com, cip-dev@lists.cip-project.org,
pavel@nabladev.com, nobuhiro.iwamatsu.x90@mail.toshiba
Subject: Re: [cip-dev] [PATCH 5.10.y-cip] thermal/drivers/renesas/rzg3s: Fix inverted reset logic in devm cleanup
Date: Thu, 29 Jan 2026 10:21:10 +0200 [thread overview]
Message-ID: <7451bd37-a7f9-4cff-9bea-ffed11c81b7e@tuxon.dev> (raw)
In-Reply-To: <20260128125830.6791-1-ovidiu.panait.rb@renesas.com>
Hi, Ovidiu,
On 1/28/26 14:58, Ovidiu Panait via lists.cip-project.org wrote:
> The devm reset callback that should undo the reset_control_deassert() done
> during probe is incorrectly calling reset_control_deassert() again,
> instead of reset_control_assert().
>
> Fix this by calling reset_control_assert() and rename the callback
> function accordingly.
>
> Fixes: c3e23a40a178 ("thermal/drivers/renesas/rzg3s: Add thermal driver for the Renesas RZ/G3S SoC")
> Signed-off-by: Ovidiu Panait<ovidiu.panait.rb@renesas.com>
Thank you for fixing this!
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
prev parent reply other threads:[~2026-01-29 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 12:58 [PATCH 5.10.y-cip] thermal/drivers/renesas/rzg3s: Fix inverted reset logic in devm cleanup Ovidiu Panait
2026-01-29 8:21 ` Claudiu Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7451bd37-a7f9-4cff-9bea-ffed11c81b7e@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pavel@nabladev.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox