[PATCH 5.10.y-cip] thermal/drivers/renesas/rzg3s: Fix inverted reset logic in devm cleanup

[PATCH 5.10.y-cip] thermal/drivers/renesas/rzg3s: Fix inverted reset logic in devm cleanup

[Ovidiu Panait]

The devm reset callback that should undo the reset_control_deassert() done
during probe is incorrectly calling reset_control_deassert() again,
instead of reset_control_assert().

Fix this by calling reset_control_assert() and rename the callback
function accordingly.

Fixes: c3e23a40a178 ("thermal/drivers/renesas/rzg3s: Add thermal driver for the Renesas RZ/G3S SoC")
Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
---
 drivers/thermal/rzg3s_thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/rzg3s_thermal.c b/drivers/thermal/rzg3s_thermal.c
index 65f00bc2f3d1..24418f46a09f 100644
--- a/drivers/thermal/rzg3s_thermal.c
+++ b/drivers/thermal/rzg3s_thermal.c
@@ -180,9 +180,9 @@ static int rzg3s_thermal_read_calib(struct rzg3s_thermal_priv *priv)
 	return 0;
 }
 
-static void rzg3s_thermal_reset_deassert(void *data)
+static void rzg3s_thermal_reset_assert(void *data)
 {
-	reset_control_deassert(data);
+	reset_control_assert(data);
 }
 
 static void rzg3s_thermal_rem_hwmon_sysfs(void *data)
@@ -223,7 +223,7 @@ static int rzg3s_thermal_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	ret = devm_add_action_or_reset(dev, rzg3s_thermal_reset_deassert, priv->rstc);
+	ret = devm_add_action_or_reset(dev, rzg3s_thermal_reset_assert, priv->rstc);
 	if (ret)
 		return ret;
 
-- 
2.51.0

Re: [cip-dev] [PATCH 5.10.y-cip] thermal/drivers/renesas/rzg3s: Fix inverted reset logic in devm cleanup

[Claudiu Beznea]

Hi, Ovidiu,

On 1/28/26 14:58, Ovidiu Panait via lists.cip-project.org wrote:
> The devm reset callback that should undo the reset_control_deassert() done
> during probe is incorrectly calling reset_control_deassert() again,
> instead of reset_control_assert().
> 
> Fix this by calling reset_control_assert() and rename the callback
> function accordingly.
> 
> Fixes: c3e23a40a178 ("thermal/drivers/renesas/rzg3s: Add thermal driver for the Renesas RZ/G3S SoC")
> Signed-off-by: Ovidiu Panait<ovidiu.panait.rb@renesas.com>

Thank you for fixing this!

Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>