Re: [isar-cip-core][PATCH 6/6] change-root-homedir: split root home move into own package

["Wang, Jing" <wangjing@siemens.com>]

Hi Henning,

Thanks for your this PATCH information! But since now I'm still NOT familiar with how to submit isar-cip-core PATCH process and also without the related account and permission, I'll appreciate you can continue this PATCH this time. Of course, I'll learn how to contribute PATCH to isar-cip-core and maybe I can take over in the future 😊

Also discussed with Martin, since this PATCH is NOT very high priority for Jupiter-core, then we might pick up the isar-cip-core latest version from master once it's integrated in the future.

Thank you so much!

BR
Wang Jing

-----Original Message-----
From: Schild, Henning (T CED SES-DE) <henning.schild@siemens.com> 
Sent: Wednesday, January 4, 2023 4:17 AM
To: Wang, Jing (DI FA CTR SVC&AI CN) <wangjing@siemens.com>
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; cip-dev@lists.cip-project.org
Subject: Re: [isar-cip-core][PATCH 6/6] change-root-homedir: split root home move into own package

Wang Jing maybe you want to address those comments and send this one again?

If so you should only use this patch, change it and add your Signed-Off. You could even make yourself the author and drop my Signed-Off if you want. I think the latter would be the best idea if you took over.

Further you want to add a cover letter where you mention that you are based on next and add a "changed since v1" section to that cover letter.

Please reply if or if not you want to continue here. I will only pick this up again when i hear from you.

Henning

Am Tue, 3 Jan 2023 17:54:25 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 02.01.23 18:08, Henning Schild wrote:
> > Changing the homedir of root that way is required by any layer that 
> > takes ro rootfs pieces from here. Making it its own package allows 
> > reuse without having to take some other customizations.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  .../change-root-homedir.bb                    |  5 +++++
> >  .../change-root-homedir/files/postinst        | 21
> > +++++++++++++++++++ recipes-core/customizations/common.inc        |
> >  5 +++-- recipes-core/customizations/files/postinst    |  8 -------
> >  4 files changed, 29 insertions(+), 10 deletions(-)  create mode 
> > 100644 recipes-core/change-root-homedir/change-root-homedir.bb 
> > create mode
> > 100644 recipes-core/change-root-homedir/files/postinst
> > 
> > diff --git
> > a/recipes-core/change-root-homedir/change-root-homedir.bb
> > b/recipes-core/change-root-homedir/change-root-homedir.bb new file 
> > mode 100644 index 000000000000..dc4631bd6b16 --- /dev/null
> > +++ b/recipes-core/change-root-homedir/change-root-homedir.bb
> > @@ -0,0 +1,5 @@
> 
> Missing copyright header.
> 
> > +inherit dpkg-raw
> > +
> > +DESCRIPTION = "Move roots homedir to /home for read-only rootfs"
> > +
> > +SRC_URI = "file://postinst"
> > diff --git a/recipes-core/change-root-homedir/files/postinst
> > b/recipes-core/change-root-homedir/files/postinst new file mode
> > 100644 index 000000000000..205ee4839e82
> > --- /dev/null
> > +++ b/recipes-core/change-root-homedir/files/postinst
> > @@ -0,0 +1,21 @@
> > +#!/bin/sh
> > +#
> > +# CIP Core, generic profile
> > +#
> > +# Copyright (c) Siemens AG, 2019
> 
> Maybe update to "2019-2023" at this chance.
> 
> > +#
> > +# Authors:
> > +#  Jan Kiszka <jan.kiszka@siemens.com> # # SPDX-License-Identifier: 
> > +MIT #
> > +
> > +set -e
> > +
> > +# needed for read-only rootfs with writable /home if [ ! -L /root 
> > +]; then
> > +	# usermod --move-home can not be used while the target user
> > +	# has running processes, also we keep a symlink here
> > +	mv /root /home/
> > +	ln -s /home/root /root
> > +fi
> > diff --git a/recipes-core/customizations/common.inc
> > b/recipes-core/customizations/common.inc index 
> > 1124ff2d3590..24c862c32e3b 100644 --- 
> > a/recipes-core/customizations/common.inc +++ 
> > b/recipes-core/customizations/common.inc @@ -22,10 +22,11 @@ SRC_URI 
> > = " \ WIRELESS_FIRMWARE_PACKAGE ?= ""
> >  INSTALL_WIRELESS_TOOLS ??= "0"
> >  
> > -DEPENDS += "sshd-regen-keys"
> > +DEPENDS += "sshd-regen-keys change-root-homedir"
> >  
> >  DEBIAN_DEPENDS = " \
> > -    ifupdown, isc-dhcp-client, net-tools, iputils-ping, ssh,
> > sshd-regen-keys \
> > +    ifupdown, isc-dhcp-client, net-tools, iputils-ping, ssh,
> > sshd-regen-keys, \
> > +    change-root-homedir \
> >      ${@(', iw, wireless-regdb, ' +
> > d.getVar('WIRELESS_FIRMWARE_PACKAGE')) \ if
> > d.getVar('INSTALL_WIRELESS_TOOLS') == '1' else ''}" 
> > diff --git a/recipes-core/customizations/files/postinst
> > b/recipes-core/customizations/files/postinst index
> > 7a0b00d98680..7e7ea3692325 100644 --- 
> > a/recipes-core/customizations/files/postinst +++ 
> > b/recipes-core/customizations/files/postinst @@ -21,11 +21,3 @@ fi  
> > HOSTNAME=demo  echo "$HOSTNAME" > /etc/hostname  echo "127.0.0.1 
> > $HOSTNAME" >> /etc/hosts
> > -
> > -# needed for read-only rootfs with writable /home -if [ ! -L /root 
> > ]; then
> > -	# usermod --move-home can not be used while the target user
> > -	# has running processes, also we keep a symlink here
> > -	mv /root /home/
> > -	ln -s /home/root /root
> > -fi
> 
> Jan
>