Re: [cip-dev] [isar-cip-core][PATCH 1/8] add recipe for edk2

["Schultschik, Sven" <sven.schultschik@siemens.com>]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

On Mon, 2023-01-09 at 08:40 +0100, Jan Kiszka wrote:
> On 09.01.23 07:42, Su, Bao Cheng (DI FA CTR IPC CN PRC4) wrote:
> > On Sun, 2022-11-20 at 21:47 +0100, Schultschik, Sven via lists.cip-
> > project.org wrote:
> > > From: Sven Schultschik <sven.schultschik@siemens.com>
> > > 
> > > provide a recipe to create the BL32_AP_MM.fd binary by edk2 which
> > > is needed for the qemu optee generation as dependency.
> 
> Should mention the StandaloneMm for RPMB, what it is and then mention
> where it will be used.
> 
> Also adjust the subject - we are not building complete EDK2.
> 
> > > 
> > > Signed-off-by: Sven Schultschik <sven.schultschik@siemens.com>
> > > ---
> > >  .../edk2/edk2-platformstandalonemmrpmb.inc    | 56
> > > +++++++++++++++++
> > >  .../edk2-platformstandalonemmrpmb_202205.bb   | 12 ++++
> 
> Recipe name became too unreadable. "edk2-standalonemm-rpmb" maybe? By
> convention, we don't use camel-cases in recipes, so this cannot help
> with separating words.
Made the changes yesterday, but as I can see you already did with the
other patch you send in.
> 
> > > 
> 
> Would be good to clarify how these revisions were selected. Do they
> come
> from the EDK2 build manifest?

Those are submodules. So look into the edk2 repo on the specific
location which version they used in the submodul at the version you
want to use edk2.
> 
> > > 
> 
> > > +export SHELL=/bin/bash
> 
> Needed?

Yes. source edk2/edksetup.sh only works under bin/bash




[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7531 bytes --]