From: Jan Kiszka <jan.kiszka@siemens.com>
To: Claudius Heine <ch@denx.de>, cip-dev@lists.cip-project.org
Subject: Re: [PATCH 1/5] initramfs-crypt-hook: make sure that mount path exists
Date: Thu, 27 Feb 2025 10:13:49 +0100 [thread overview]
Message-ID: <9cab7415-e5fd-4a3e-a36b-70128dfd97a2@siemens.com> (raw)
In-Reply-To: <20250226095921.168962-2-ch@denx.de>
On 26.02.25 10:59, Claudius Heine wrote:
> In case the mount path does not exist, try to create it instead of
> failing.
>
Please specify the "why" here. As you know, (almost) every commit
message should cover that, and obvious ones do not even have to talk
about how they do that.
Jan
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> .../initramfs-crypt-hook/files/local-bottom-complete | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-initramfs/initramfs-crypt-hook/files/local-bottom-complete b/recipes-initramfs/initramfs-crypt-hook/files/local-bottom-complete
> index b991cb4..80553d1 100644
> --- a/recipes-initramfs/initramfs-crypt-hook/files/local-bottom-complete
> +++ b/recipes-initramfs/initramfs-crypt-hook/files/local-bottom-complete
> @@ -41,6 +41,7 @@ mount_partition() {
> partition_mountpoint=$2
> [ "$debug" = "y" ] && echo "mount device: '$partition_dev_path' to '$partition_mountpoint'"
> if ! mountpoint -q "${partition_mountpoint}"; then
> + mkdir -p "${partition_mountpoint}"
> if ! mount -t "$(get_fstype "${partition_dev_path}")" "${partition_dev_path}" \
> "${partition_mountpoint}"; then
> panic "Can't mount partition '${partition_dev_path}'!"
--
Siemens AG, Foundational Technologies
Linux Expert Center
next prev parent reply other threads:[~2025-02-27 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 9:59 [PATCH 0/5] Initramfs-crypt-hook patches, encryption on update Claudius Heine
2025-02-26 9:59 ` [PATCH 1/5] initramfs-crypt-hook: make sure that mount path exists Claudius Heine
2025-02-27 9:13 ` Jan Kiszka [this message]
2025-02-26 9:59 ` [PATCH 2/5] initramfs-crypt-hook: fix inconsistent whitespace Claudius Heine
2025-02-27 9:14 ` Jan Kiszka
2025-02-26 9:59 ` [PATCH 3/5] initramfs-crypt-hook: use real device path in luksFormat case Claudius Heine
2025-02-27 9:16 ` Jan Kiszka
2025-02-27 12:47 ` Quirin Gylstorff
2025-02-27 12:49 ` Jan Kiszka
2025-02-26 9:59 ` [PATCH 4/5] initramfs-crypt-hook: implement 'noencrypt' option Claudius Heine
2025-02-27 9:17 ` Jan Kiszka
2025-02-27 9:55 ` Claudius Heine
2025-02-27 12:48 ` Jan Kiszka
2025-02-27 13:16 ` [cip-dev] " Quirin Gylstorff
2025-02-27 14:04 ` Claudius Heine
2025-02-26 9:59 ` [PATCH 5/5] initramfs-crypt-hook: add 'format-if-empty' feature Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cab7415-e5fd-4a3e-a36b-70128dfd97a2@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ch@denx.de \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox