From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E8B4C636CD for ; Wed, 1 Feb 2023 13:04:52 +0000 (UTC) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.groups.io with SMTP id smtpd.web10.21819.1675254787644363755 for ; Wed, 01 Feb 2023 04:33:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OKOKc9ga; spf=pass (domain: gmail.com, ip: 209.85.128.47, mailfrom: error27@gmail.com) Received: by mail-wm1-f47.google.com with SMTP id l8so12550971wms.3 for ; Wed, 01 Feb 2023 04:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=XRmrbfafZ2u/Btz65QhA5W17LjiB4tALokKgI/W8edE=; b=OKOKc9gas9i2/PI5SMgZnB9jaLNLXNIkaffBPLn1343o1kpur9OYxFCqr9INgZFh8L HdR11x0E2mbBcYSrJPYzqMNTUXDz3ZPbkrBVhujkeXkogNAOhutMeEG1djXOU2Id/zox zZH4DzAXzpRcj0bpNy9hREdiIhZh58ujg3yb7BoswLg4cCVzyA4jVE5W6EHga6s/gIwH BjzOC0q/jSYz5+8/M57hxCEaVaqmWYe2CiEBM0oLOUSyU0zwOOiyP4TLS3OVJo8W8ih7 VxIchOvu0Oc0btv6Yw7nl/Kx9vwqmmxSSseqrLlmylEnBq8A8cV1IN5Ja172UyMYnqit jnKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XRmrbfafZ2u/Btz65QhA5W17LjiB4tALokKgI/W8edE=; b=uICGNRqosxiDTS+a4EJnvNT02KFsYH0ymo4wP586t8x1NM1AaSOQ55bGwYcWnubc7u A4rhUdX9cr78W+vXHzH/bc/PUEdUoqpJRT64zwVrLOyLPjvyS8ToJpEOgCzR3SSQQbpM tXjVRCMTiYh6doZf8G+Bx19YiNj5zEyYGoDIca8nmSrKM/PAE7cosw0gJm09KpGN1YNP nqGYnY3xGU+5+G+gvXn1sk7sq6VoTJnTuYDGX83nPwuaDLNhhcTLpmXcjAE62xTl3YBq wN6Rz6c7QYbU5jlr+pNlamvw4BAY4pIaS3zSjqH336zeoUFV72FF1HaIacGHJ4bTmvWy fqsA== X-Gm-Message-State: AO0yUKUq5OH4l5FOGOqkqOQd6xcd8QGROZD934DvEqZhaX1MBZezb8Op Pz3BwUe9jPjKH5emUGMl6cI= X-Google-Smtp-Source: AK7set8IgVC7vdS6cBbDvuHVO8lLXGXyLSwCKEJNifcWGmdpgNJfoljKHfM3mylXBNRRo0xTqrEeSA== X-Received: by 2002:a1c:4c17:0:b0:3db:262a:8ef with SMTP id z23-20020a1c4c17000000b003db262a08efmr1924583wmf.38.1675254785897; Wed, 01 Feb 2023 04:33:05 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0a4c00b003dc4b4dea31sm1889127wmq.27.2023.02.01.04.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 04:33:05 -0800 (PST) Date: Wed, 1 Feb 2023 15:32:42 +0300 From: Dan Carpenter To: okaya@codeaurora.org Cc: dmaengine@vger.kernel.org, Masami Ichikawa , cip-dev Subject: [bug report] dmaengine: add Qualcomm Technologies HIDMA management driver Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 01 Feb 2023 13:04:52 -0000 X-Groupsio-URL: https://lists.cip-project.org/g/cip-dev/message/10556 Hello Sinan Kaya, The patch 7f8f209fd6e0: "dmaengine: add Qualcomm Technologies HIDMA management driver" from Feb 4, 2016, leads to the following Smatch static checker warning: drivers/dma/qcom/hidma_mgmt.c:101 hidma_mgmt_setup() warn: uncapped user loop index 'i' drivers/dma/qcom/hidma_mgmt.c 91 } 92 93 if (mgmtdev->max_rd_xactions > HIDMA_MAX_RD_XACTIONS_MASK) { 94 dev_err(&mgmtdev->pdev->dev, 95 "max_rd_xactions cannot be bigger than %ld\n", 96 HIDMA_MAX_RD_XACTIONS_MASK); 97 return -EINVAL; 98 } 99 100 for (i = 0; i < mgmtdev->dma_channels; i++) { --> 101 if (mgmtdev->priority[i] > 1) { ^^^^^^^^^^^^^^^^^^^^ The sysfs interface lets you set mgmtdev->dma_channels so this is an array out of bounds access. It's in hidma_mgmt_sys.c drivers/dma/qcom/hidma_mgmt_sys.c 26 #define IMPLEMENT_GETSET(name) \ 27 static int get_##name(struct hidma_mgmt_dev *mdev) \ 28 { \ 29 return mdev->name; \ 30 } \ 31 static int set_##name(struct hidma_mgmt_dev *mdev, u64 val) \ 32 { \ 33 u64 tmp; \ 34 int rc; \ 35 \ 36 tmp = mdev->name; \ 37 mdev->name = val; \ 38 rc = hidma_mgmt_setup(mdev); \ 39 if (rc) \ 40 mdev->name = tmp; \ 41 return rc; \ 42 } 43 44 #define DECLARE_ATTRIBUTE(name, mode) \ 45 {#name, mode, get_##name, set_##name} 46 47 IMPLEMENT_GETSET(hw_version_major) 48 IMPLEMENT_GETSET(hw_version_minor) 49 IMPLEMENT_GETSET(max_wr_xactions) 50 IMPLEMENT_GETSET(max_rd_xactions) 51 IMPLEMENT_GETSET(max_write_request) 52 IMPLEMENT_GETSET(max_read_request) 53 IMPLEMENT_GETSET(dma_channels) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 54 IMPLEMENT_GETSET(chreset_timeout_cycles) regards, dan carpenter