public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	tomm.merciai@gmail.com
Subject: Re: [PATCH 6.1.y-cip 8/9] i2c: riic: Add support for R9A09G057 SoC
Date: Fri, 4 Apr 2025 12:47:34 +0200	[thread overview]
Message-ID: <Z++4xs9HFKVAbicJ@duo.ucw.cz> (raw)
In-Reply-To: <20250404073819.173272-9-tommaso.merciai.xr@bp.renesas.com>

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Hi!

> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> commit a45f95d7480544fdaa9d566cb4956d0ca5d0dc33 upstream.
> 
> Extend the RIIC driver to support the RZ/V2H(P) ("R9A09G057") SoC. It
> accomplishes this by appending the compatible string list and passing
> the RZ/V2H-specific OF data.
> 
> +++ b/drivers/i2c/busses/i2c-riic.c
> @@ -526,8 +526,25 @@ static const struct riic_of_data riic_rz_a_info = {
>  	},
>  };
>  
> +static const struct riic_of_data riic_rz_v2h_info = {
> +	.regs = {
> +		[RIIC_ICCR1] = 0x00,
> +		[RIIC_ICCR2] = 0x01,
> +		[RIIC_ICMR1] = 0x02,
> +		[RIIC_ICMR3] = 0x04,
> +		[RIIC_ICSER] = 0x06,
> +		[RIIC_ICIER] = 0x07,
> +		[RIIC_ICSR2] = 0x09,
> +		[RIIC_ICBRL] = 0x10,
> +		[RIIC_ICBRH] = 0x11,
> +		[RIIC_ICDRT] = 0x12,
> +		[RIIC_ICDRR] = 0x13,
> +	},
> +};

Word-size registers one byte apart? How does that work?

Ok, never mind, just curious.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2025-04-04 10:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  7:38 [PATCH 6.1.y-cip 0/9] Add RZ/G3E RIIC support Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 1/9] clk: renesas: r9a09g047: Add I2C clocks/resets Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 2/9] dt-bindings: i2c: renesas,riic: Document RZ/Five SoC Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 3/9] dt-bindings: i2c: renesas,riic: Document R9A09G057 support Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 4/9] dt-bindings: i2c: renesas,riic: Document the R9A08G045 support Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 5/9] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 6/9] i2c: riic: Introduce helper functions for I2C read/write operations Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 7/9] i2c: riic: Pass register offsets and chip details as OF data Tommaso Merciai
2025-04-04  7:38 ` [PATCH 6.1.y-cip 8/9] i2c: riic: Add support for R9A09G057 SoC Tommaso Merciai
2025-04-04 10:47   ` Pavel Machek [this message]
2025-04-04  7:38 ` [PATCH 6.1.y-cip 9/9] arm64: dts: renesas: r9a09g047: Add I2C nodes Tommaso Merciai
2025-04-04 10:49 ` [PATCH 6.1.y-cip 0/9] Add RZ/G3E RIIC support Pavel Machek
2025-04-07  7:49 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z++4xs9HFKVAbicJ@duo.ucw.cz \
    --to=pavel@denx.de \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=tomm.merciai@gmail.com \
    --cc=tommaso.merciai.xr@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox