From: Pavel Machek <pavel@denx.de>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: nobuhiro1.iwamatsu@toshiba.co.jp, pavel@denx.de,
cip-dev@lists.cip-project.org, biju.das.jz@bp.renesas.com,
prabhakar.mahadev-lad.rj@bp.renesas.com
Subject: Re: [cip dev][PATCH 6.1.y-cip 0/8] watchdog: rzg2l_wdt: Backport RZ/G3S support
Date: Thu, 19 Dec 2024 19:25:37 +0100 [thread overview]
Message-ID: <Z2RlIUU0vCUjnmTF@duo.ucw.cz> (raw)
In-Reply-To: <20241218122246.2365189-1-claudiu.beznea.uj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Hi!
> Series backports the watchdog support for the Renesas RZ/G3S SoC.
Applied, but there may be more work to do there.
rzg2l_wdt.c:
rzg2l_wdt_start
/* Enable watchdog timer*/
-> "timer */"
static int rzg2l_wdt_stop(struct watchdog_device *wdev)
We can now fail to stop the watchdog.. not sure how well core can
handle that. If pm_runtime_put fails, we return error, but we already
toggled the reset control. Should we undo that? Does error handling
here make sense at all?
rzg2l_wdt_restart:
Similar problem. If reset_control_deassert() fails, we should probably
do pm_runtime_put().
Thanks and best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2024-12-19 18:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 12:22 [cip dev][PATCH 6.1.y-cip 0/8] watchdog: rzg2l_wdt: Backport RZ/G3S support Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 1/8] clk: renesas: r9a08g045: Add clock and reset support for watchdog Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 2/8] watchdog: rzg2l_wdt: Remove reset de-assert from probe Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 3/8] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 4/8] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 5/8] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 6/8] watchdog: rzg2l_wdt: Power on the watchdog domain in the restart handler Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 7/8] arm64: dts: renesas: r9a08g045: Add watchdog node Claudiu
2024-12-18 12:22 ` [cip dev][PATCH 6.1.y-cip 8/8] arm64: dts: renesas: rzg3s-smarc-som: Enable the watchdog interface Claudiu
2024-12-19 1:05 ` [cip dev][PATCH 6.1.y-cip 0/8] watchdog: rzg2l_wdt: Backport RZ/G3S support nobuhiro1.iwamatsu
2024-12-19 18:14 ` Pavel Machek
2024-12-19 18:25 ` Pavel Machek [this message]
2024-12-20 9:05 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2RlIUU0vCUjnmTF@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox