From: Pavel Machek <pavel@denx.de>
To: cip-dev@lists.cip-project.org
Cc: Ulrich Hecht <uli@kernel.org>,
Liam Howlett <liam.howlett@oracle.com>,
Michael Schmitz <schmitzmic@gmail.com>,
linux-m68k@lists.linux-m68k.org
Subject: Re: [cip-dev] [PATCH 4.4.y-cip] m68k: Add missing mmap_read_lock() to sys_cacheflush()
Date: Sat, 22 Feb 2025 10:37:41 +0100 [thread overview]
Message-ID: <Z7ma5eOlH/k0fgRg@duo.ucw.cz> (raw)
In-Reply-To: <9a7bb5ad805dbb1c8a67186f04500474@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi!
> From: Liam Howlett <liam.howlett@oracle.com>
>
> [ Upstream commit f829b4b212a315b912cb23fd10aaf30534bb5ce9 ]
>
> When the superuser flushes the entire cache, the mmap_read_lock() is not
> taken, but mmap_read_unlock() is called. Add the missing
> mmap_read_lock() call.
>
> Fixes: cd2567b6850b1648 ("m68k: call find_vma with the mmap_sem held in sys_cacheflush()")
> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Link: https://lore.kernel.org/r/20210407200032.764445-1-Liam.Howlett@Oracle.com
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> [ mmap_read_lock() open-coded using down_read() as was done prior to v5.8 ]
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Reviewed-by: Pavel Machek <pavel@denx.de>
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2025-02-22 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 7:21 [PATCH 4.4.y-cip] m68k: Add missing mmap_read_lock() to sys_cacheflush() Finn Thain
2025-02-22 9:37 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7ma5eOlH/k0fgRg@duo.ucw.cz \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
--cc=liam.howlett@oracle.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=uli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox