From: Pavel Machek <pavel@denx.de>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
tomm.merciai@gmail.com
Subject: Re: [PATCH 6.1.y-cip 06/12] serial: sh-sci: describe locking requirements for invalidating RXDMA
Date: Wed, 19 Mar 2025 11:20:06 +0100 [thread overview]
Message-ID: <Z9qaVlIje4J2ZcWh@duo.ucw.cz> (raw)
In-Reply-To: <20250319094754.2404386-7-tommaso.merciai.xr@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
Hi!
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> commit 8efc440549087de41abadf62f4bde1d827135338 upstream.
>
> Make sure everyone knows that calling this function needs protection.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Link: https://lore.kernel.org/r/20240506114016.30498-8-wsa+renesas@sang-engineering.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/sh-sci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 69f8ac561513..7c93c9a1079b 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -1264,6 +1264,7 @@ static int sci_dma_rx_find_active(struct sci_port *s)
> return -1;
> }
>
> +/* Must only be called with uart_port_lock taken */
> static void sci_dma_rx_chan_invalidate(struct sci_port *s)
> {
> unsigned int i;
Instead of comment, would lockdep_assert(...) be better / more robust
way to accomplish this?
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-03-19 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 9:47 [PATCH 6.1.y-cip 00/12] serial: sh-sci: Add support for RZ/G3E serial driver Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 01/12] dt-bindings: serial: renesas,scif: Move ref for serial.yaml at the end Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 02/12] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt-names' Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 03/12] dt-bindings: serial: renesas,scif: Make 'interrupt-names' property as required Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 04/12] dt-bindings: serial: Add documentation for Renesas RZ/V2H(P) (R9A09G057) SCIF support Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 05/12] dt-bindings: serial: renesas: Document RZ/G3E (r9a09g047) scif Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 06/12] serial: sh-sci: describe locking requirements for invalidating RXDMA Tommaso Merciai
2025-03-19 10:20 ` Pavel Machek [this message]
2025-03-19 9:47 ` [PATCH 6.1.y-cip 07/12] serial: sh-sci: Add support for RZ/V2H(P) SoC Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 08/12] serial: sh-sci: Use plain struct copy in early_console_setup() Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 09/12] serial: sh-sci: Check if TX data was written to device in .tx_empty() Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 10/12] serial: sh-sci: Move runtime PM enable to sci_probe_single() Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 11/12] serial: sh-sci: Clean sci_ports[0] after at earlycon exit Tommaso Merciai
2025-03-19 9:47 ` [PATCH 6.1.y-cip 12/12] serial: sh-sci: Increment the runtime usage counter for the earlycon device Tommaso Merciai
2025-03-19 10:13 ` [PATCH 6.1.y-cip 00/12] serial: sh-sci: Add support for RZ/G3E serial driver Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9qaVlIje4J2ZcWh@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox