Request for reviews for 4.4-st40, 4.4-cip75

Request for reviews for 4.4-st40, 4.4-cip75

[Ulrich Hecht]

Hi!

Here are the manual backports for the upcoming 4.4-st40 and 4.4-cip75 releases that should be reviewed, and that can currently be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc

Trivial backports:

** m | 3c29c13c3 968b66 o+ | hwmon (it87): Fix voltage scaling for chips with 10.9mV ADCs
** m | 36bfbaa29 b871cb .+ | ALSA: hda/conexant: Partial revert of a quirk for Lenovo
** m | 1487976d3 c17f8f f  | ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard
** m | 078465f34 bf8493 .+ | coresight-etm4: Fix for() loop drvdata->nr_addr_cmp range bug
** m | e10703fd5 5d8d4a o+ | arm64: KVM: Fix system register enumeration
** m | 3d081d862 c86c00 o+ | i40e: fix i40e_setup_misc_vector() error handling
** m | bff19445c ef8327 o  | nilfs2: initialize unused bytes in segment summary blocks

Not completely trivial backports:

** m | 38d976de6 621489 o+ | hvc/xen: prevent concurrent accesses to the shared ring
** m | 1629f6f52 90410b o+ | ocfs2: fix data corruption after failed write

This is a rather convoluted way to insert a missing prerequisite. It had to be backported because the reverted patch was also a manual backport:

** m | 65cb67402 67d7d8 o  | Revert "ext4: fix use-after-free in ext4_xattr_set_entry"
** m | 0a8cff7f0 310c09 o  | ext4: remove duplicate definition of ext4_xattr_ibody_inline_set()
** m | 322d238b7 67d7d8 o  | ext4: fix use-after-free in ext4_xattr_set_entry

Thanks!

CU
Uli

Re: Request for reviews for 4.4-st40, 4.4-cip75

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

Hi!

> Here are the manual backports for the upcoming 4.4-st40 and 4.4-cip75 releases that should be reviewed, and that can currently be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
> 
> Trivial backports:

These seem ok.

a | 3c29c13c3 968b66 o+ | hwmon (it87): Fix voltage scaling for chips with 10.9mV ADCs
a | 36bfbaa29 b871cb .+ | ALSA: hda/conexant: Partial revert of a quirk for Lenovo
a | 1487976d3 c17f8f f  | ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard
a | 078465f34 bf8493 .+ | coresight-etm4: Fix for() loop drvdata->nr_addr_cmp range bug
a | bff19445c ef8327 o  | nilfs2: initialize unused bytes in segment summary blocks

Can you doublecheck these?

> ** m | e10703fd5 5d8d4a o+ | arm64: KVM: Fix system register enumeration

AFAICT kvm_arm_copy_core_reg_indices() does not have the problem
described in the changelog, so no change is
neccessary. copy_timer_indices() in 4.4 always return 0 or -EFAULT, so
it does not need changing, either.

> ** m | 3d081d862 c86c00 o+ | i40e: fix i40e_setup_misc_vector() error handling

AFAICT this should be going to end_unlock.

> Not completely trivial backports:

They seem ok.

a | 38d976de6 621489 o+ | hvc/xen: prevent concurrent accesses to the shared ring
a | 1629f6f52 90410b o+ | ocfs2: fix data corruption after failed write

> This is a rather convoluted way to insert a missing prerequisite. It had to be backported because the reverted patch was also a manual backport:

Yep, I seen the "fun" in newer kernels. No problems found here.

a | 65cb67402 67d7d8 o  | Revert "ext4: fix use-after-free in ext4_xattr_set_entry"
a | 0a8cff7f0 310c09 o  | ext4: remove duplicate definition of ext4_xattr_ibody_inline_set()
a | 322d238b7 67d7d8 o  | ext4: fix use-after-free in ext4_xattr_set_entry

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [cip-dev] Request for reviews for 4.4-st40, 4.4-cip75

[Ulrich Hecht]

Thanks for the reviews.

> On 04/30/2023 11:54 AM CEST Pavel Machek <pavel@denx.de> wrote:
> > ** m | e10703fd5 5d8d4a o+ | arm64: KVM: Fix system register enumeration
> 
> AFAICT kvm_arm_copy_core_reg_indices() does not have the problem
> described in the changelog, so no change is
> neccessary. copy_timer_indices() in 4.4 always return 0 or -EFAULT, so
> it does not need changing, either.

Indeed; I'll drop it.

> > ** m | 3d081d862 c86c00 o+ | i40e: fix i40e_setup_misc_vector() error handling
> 
> AFAICT this should be going to end_unlock.

There is no end_unlock, because their is no lock here in 4.4.
(That's why it needed a backport in the first place.)

CU
Uli

Re: [cip-dev] Request for reviews for 4.4-st40, 4.4-cip75

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hi!

> > AFAICT kvm_arm_copy_core_reg_indices() does not have the problem
> > described in the changelog, so no change is
> > neccessary. copy_timer_indices() in 4.4 always return 0 or -EFAULT, so
> > it does not need changing, either.
> 
> Indeed; I'll drop it.

Thank you.

> > > ** m | 3d081d862 c86c00 o+ | i40e: fix i40e_setup_misc_vector() error handling
> > 
> > AFAICT this should be going to end_unlock.
> 
> There is no end_unlock, because their is no lock here in 4.4.
> (That's why it needed a backport in the first place.)

Sorry about this, you are right, I was likely looking at wrong
version.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]