public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Subject: Re: [PATCH 5.10.y-cip 0/2] watchdog: iTCO_wdt: Backport patches to enable handle_boot_enabled=0
Date: Wed, 19 Jul 2023 13:23:23 +0200	[thread overview]
Message-ID: <ZLfHq5APB5ME5IYC@duo.ucw.cz> (raw)
In-Reply-To: <cover.1689699632.git.jan.kiszka@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

Hi!

> These patches are needed in order to make iTCO_wdt respect
> handle_boot_enabled=0, i.e. to step back from a running watchdog until
> userspace picks it up. Up to 5.16, the driver simply stopped the
> watchdog which could have created a non-monitored window during boot-up
> in the handover from the firmware starting it to userspace (typically
> sytemd) safely driving. E.g., any infinite loops in the initramfs would
> could have created a locked-up system.
> 
> These patches were proposed to the watchdog maintainers for official
> stable integration  [1] but received no reaction so far. As the issue is critical for
> CIP's OTA software update integration, let's use the CIP path
> instead.

So... these are mainline, but -stable failed to react. Rules say we
can take them.

Both patches are in 6.1, so we don't need to port it there.

And I don't see anything horribly wrong; I propose we apply them if
they pass testing.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

      parent reply	other threads:[~2023-07-19 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 17:00 [PATCH 5.10.y-cip 0/2] watchdog: iTCO_wdt: Backport patches to enable handle_boot_enabled=0 Jan Kiszka
2023-07-18 17:00 ` [PATCH 5.10.y-cip 1/2] watchdog: iTCO_wdt: No need to stop the timer in probe Jan Kiszka
2023-07-18 17:00 ` [PATCH 5.10.y-cip 2/2] watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running Jan Kiszka
2023-07-18 23:57 ` [PATCH 5.10.y-cip 0/2] watchdog: iTCO_wdt: Backport patches to enable handle_boot_enabled=0 nobuhiro1.iwamatsu
2023-07-19 11:23 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLfHq5APB5ME5IYC@duo.ucw.cz \
    --to=pavel@denx.de \
    --cc=cip-dev@lists.cip-project.org \
    --cc=jan.kiszka@siemens.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox