Re: [PATCH 6.1.y-cip 04/13] dt-bindings: rtc: isl1208: Convert to json-schema

Pavel Machek
2023-08-17T11:11:18Z

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi!

> +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> @@ -0,0 +1,89 @@
> + isil,ev-evienb:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 0, 1 ]
> + description: |
> + Enable or disable internal pull on EVIN pin

Add "." at end of line.

> + Default will leave the non-volatile configuration of the pullup

"By default driver will not touch the configuration of the pullup"?

> + as is.
> + <0> : Enables internal pull-up on evin pin
> + <1> : Disables internal pull-up on evin pin

Too late to change this but logic seems inverted from what
"isil,ev-evienb" suggests. Other dts-es spell xxx-pull-up.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]