Re: [PATCH 6.1.y-cip 02/13] regulator: Add Renesas PMIC RAA215300 driver

Pavel Machek
2023-08-18T07:31:40Z

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

Hi!

> > > + /*Clear the latched registers */
> >
> > "/* Clear". I would not mind checking errors from regmap here.
>
> OK, will fix it. I checked most of the drivers are not doing
> Checks for regmap in kernel. As you suggested will do it here.

Up to you really. I doubt regmap will fail in any real situation. I
just noticed because you do check errors on the first one.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]