RE: [PATCH 6.1.y-cip 04/13] dt-bindings: rtc: isl1208: Convert to json-schema

Biju Das
2023-08-17T11:23:38Z

Hi Pavel Machek,

Thanks for the feedback.

> Subject: Re: [PATCH 6.1.y-cip 04/13] dt-bindings: rtc: isl1208: Convert to
> json-schema
>
> Hi!
>
> > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> > @@ -0,0 +1,89 @@
> > + isil,ev-evienb:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 0, 1 ]
> > + description: |
> > + Enable or disable internal pull on EVIN pin
>
> Add "." at end of line.

It is just cut + paste from .txt file [1]
[1] https://elixir.bootlin.com/linux/v6.1.46/source/Documentation/devicetree/bindings/rtc/isil,isl1208.txt

>
> > + Default will leave the non-volatile configuration of the pullup
>
> "By default driver will not touch the configuration of the pullup"?
>
> > + as is.
> > + <0> : Enables internal pull-up on evin pin
> > + <1> : Disables internal pull-up on evin pin
>
> Too late to change this but logic seems inverted from what "isil,ev-evienb"
> suggests. Other dts-es spell xxx-pull-up.

I agree.

Cheers,
Biju