RE: [PATCH 6.1.y-cip 01/13] regulator: dt-bindings: Add Renesas RAA215300 PMIC bindings

Biju Das
2023-08-17T11:18:38Z

Hi Pavel,

Thanks for the feedback.

> Subject: Re: [PATCH 6.1.y-cip 01/13] regulator: dt-bindings: Add Renesas
> RAA215300 PMIC bindings
>
> Hi!
>
> > +++ b/Documentation/devicetree/bindings/regulator/renesas,raa215300.ya
> > +++ ml
> > @@ -0,0 +1,85 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/renesas,raa215300.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC)
> > +
> > +maintainers:
> > + - Biju Das <biju.das.jz@bp.renesas.com>
> > +
> > +description: |
> > + The RAA215300 is a high-performance, low-cost 9-channel PMIC
> > +designed for
> > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3,
> > +DDR3L, DDR4,
> > + and LPDDR4 memory power requirements. The internally compensated
> > +regulators,
> > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin
> > +cell
> > + battery charger provide a highly integrated, small footprint power
> > +solution
> > + ideal for System-On-Module (SOM) applications. A spread spectrum
> > +feature
> > + provides an ease-of-use solution for noise-sensitive audio or RF
> applications.
>
> "an easy-to-use"?

It is from hardware manual.

"A spread spectrum feature provides an ease-of-use solution for
noise-sensitive audio or RF applications."

I will discuss this internally, if required will ask HW manual to fix this and then will update bindings. They are going to update the HW manual soon.

>
> > + description: |
> > + The clocks are optional. The RTC is disabled, if no clocks are
> > + provided(either xin or clkin).
>
> "If no clocks are provided (neither xin nor clkin), the RTC is disabled"?

Ok. If required, along with above change will update this as well.

Cheers,
Biju