From: Pavel Machek <pavel@denx.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 6.1.y-cip 07/13] rtc: isl1208: Make similar I2C and DT-based matching table
Date: Thu, 17 Aug 2023 13:11:45 +0200 [thread overview]
Message-ID: <ZN4AcXTOMBfKBtt3@duo.ucw.cz> (raw)
In-Reply-To: <20230816142458.147476-8-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
Hi!
> commit fbc06a53561c64ec6d7f9a1b3bc04597de4cbb2d upstream.
>
> +++ b/drivers/rtc/rtc-isl1208.c
> @@ -90,10 +90,10 @@ static const struct isl1208_config {
> };
>
> static const struct i2c_device_id isl1208_id[] = {
> - { "isl1208", TYPE_ISL1208 },
> - { "isl1209", TYPE_ISL1209 },
> - { "isl1218", TYPE_ISL1218 },
> - { "isl1219", TYPE_ISL1219 },
> + { "isl1208", .driver_data = (kernel_ulong_t)&isl1208_configs[TYPE_ISL1208] },
> + { "isl1209", .driver_data = (kernel_ulong_t)&isl1208_configs[TYPE_ISL1209] },
> + { "isl1218", .driver_data = (kernel_ulong_t)&isl1208_configs[TYPE_ISL1218] },
> + { "isl1219", .driver_data = (kernel_ulong_t)&isl1208_configs[TYPE_ISL1219] },
I'd expect to see "(unsigned long)" here.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-08-17 11:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 14:24 [PATCH 6.1.y-cip 00/13] Add Renesas PMIC RAA215300 driver and builtin RTC support Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 01/13] regulator: dt-bindings: Add Renesas RAA215300 PMIC bindings Biju Das
2023-08-17 11:03 ` Pavel Machek
2023-08-17 11:18 ` Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 02/13] regulator: Add Renesas PMIC RAA215300 driver Biju Das
2023-08-17 11:06 ` Pavel Machek
2023-08-17 11:42 ` Biju Das
2023-08-18 7:31 ` Pavel Machek
2023-08-18 7:33 ` Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 03/13] regulator: raa215300: Add build dependency with COMMON_CLK Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 04/13] dt-bindings: rtc: isl1208: Convert to json-schema Biju Das
2023-08-17 11:11 ` Pavel Machek
2023-08-17 11:23 ` Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 05/13] dt-bindings: rtc: isil,isl1208: Document clock and clock-names properties Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 06/13] rtc: isl1208: Drop name variable Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 07/13] rtc: isl1208: Make similar I2C and DT-based matching table Biju Das
2023-08-17 11:11 ` Pavel Machek [this message]
2023-08-17 11:25 ` Biju Das
2023-08-17 13:23 ` Pavel Machek
2023-08-16 14:24 ` [PATCH 6.1.y-cip 08/13] rtc: isl1208: Drop enum isl1208_id and split isl1208_configs[] Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 09/13] rtc: isl1208: Add isl1208_set_xtoscb() Biju Das
2023-08-17 11:16 ` Pavel Machek
2023-08-17 11:33 ` Biju Das
2023-08-17 13:27 ` Pavel Machek
2023-08-17 13:43 ` Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 10/13] rtc: isl1208: Add support for the built-in RTC on the PMIC RAA215300 Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 11/13] arm64: defconfig: Enable PMIC RAA215300 and RTC ISL 1208 configs Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 12/13] arm64: dts: renesas: rzg2l-smarc-som: Enable PMIC and built-in RTC Biju Das
2023-08-16 14:24 ` [PATCH 6.1.y-cip 13/13] arm64: dts: renesas: rzg2lc-smarc-som: " Biju Das
2023-08-17 11:01 ` [PATCH 6.1.y-cip 00/13] Add Renesas PMIC RAA215300 driver and builtin RTC support Pavel Machek
2023-08-19 17:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN4AcXTOMBfKBtt3@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox