From: Pavel Machek <pavel@denx.de>
To: Ulrich Hecht <uli@fpond.eu>
Cc: cip-dev@lists.cip-project.org, Pavel Machek <pavel@denx.de>
Subject: Re: [cip-dev] Request for reviews for 4.4-st44 4.4-cip79
Date: Mon, 11 Sep 2023 10:27:30 +0200 [thread overview]
Message-ID: <ZP7PcjqsgXlrMHj7@duo.ucw.cz> (raw)
In-Reply-To: <342239032.350330.1693989175762@webmail.strato.com>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
Hi!
> Thanks for the reviews!
>
> > On 09/04/2023 1:43 PM CEST Pavel Machek <pavel@denx.de> wrote:
> > Most look okay to me. I'd not put too much work with READ_ONCE
> > annotations or qla2xxx warning tweaks, they don't really fix any real
> > bugs. "ext2: Drop fragment support" probably does not hurt, but surely
> > does not fix anything. I guess we can keep it when -stable took it,
> > but...
>
> I'm inclined to include such things if they are trivial to adjust because I think it will save time fixing up future patches.
>
> > "usb: ohci-at91: Fix the unhandle interrupt when resume" is wrong, it
> > should do ohci_resume() once, not twice.
>
> Correct, I'll fix that up.
>
> > "netfilter: conntrack: Avoid nf_ct_helper_hash uses after free" is at
> > least incomplete -- nf_conntrack_helper_init() does not set the hash
> > to NULL in the error path. (Mainline does not have that bug, and code
> > change a lot there).
>
> Seems like that applies to all backports between 4.14 and 5.10, at least. I'll leave that out for now and ask stable about it.
Thank you!
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2023-09-11 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:43 Request for reviews for 4.4-st44 4.4-cip79 Ulrich Hecht
2023-09-04 10:42 ` Pavel Machek
2023-09-04 11:43 ` Pavel Machek
2023-09-06 8:32 ` [cip-dev] " Ulrich Hecht
2023-09-11 8:27 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP7PcjqsgXlrMHj7@duo.ucw.cz \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox