From: Pavel Machek <pavel@denx.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Pavel Machek <pavel@denx.de>,
cip-dev <cip-dev@lists.cip-project.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Subject: Re: Potential ext4 corruption in 6.1.64-cip10
Date: Mon, 11 Dec 2023 10:53:02 +0100 [thread overview]
Message-ID: <ZXbb/i1HuG0yPHXi@duo.ucw.cz> (raw)
In-Reply-To: <d3b38c88-34db-42cc-8f56-7fc8b4696fd0@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]
Hi!
> >> seems also our 6.1 CIP kernel is affected by [1]. Please do not use in
> >> production if you have an ext4 filesystem!
> >
> > This seems to affect O_SYNC / O_DIRECT users, so I'm not sure how
> > common problem that is.
>
> Well, Debian considered it grave:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057843
Aha, thanks for a hint, there are good pointers in that.
> > 6.1.66 is out, and there's matching 6.1.66-rt. I can release one or
> > both, but I don't see any confirmation that it is fixed in .66 or how.
> >
>
> I would expect some reference to this commit in 6.1.y as well, but there
> is nothing yet, no commit after dc4542861ec8dde92c3c8a5139bc412860aebe60
> touching that file.
So this should be fixed in
commit ea574927fc0bc343016ea3337fcfc0b3fb26fe08
Author: Christoph Hellwig <hch@lst.de>
Date: Thu Jun 1 16:58:54 2023 +0200
iomap: update ki_pos a little later in iomap_dio_complete
commit 936e114a245b6e38e0dbf706a67e7611fc993da1 upstream.
Move the ki_pos update down a bit to prepare for a better common helper
that invalidates pages based of an iocb.
Link: https://lkml.kernel.org/r/20230601145904.1385409-3-hch@lst.de
...and that's indeed in 6.1.66, and looks like it fixes relevant area.
I'll just do 6.1.66 based -cip and -cip-rt releases, unless someone
stops me.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-12-11 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 6:33 Potential ext4 corruption in 6.1.64-cip10 Jan Kiszka
2023-12-11 9:36 ` Pavel Machek
2023-12-11 9:42 ` Jan Kiszka
2023-12-11 9:53 ` Pavel Machek [this message]
2023-12-11 9:58 ` Jan Kiszka
2023-12-11 20:27 ` WIFI in 6.1.X was " Pavel Machek
2023-12-12 5:38 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXbb/i1HuG0yPHXi@duo.ucw.cz \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
--cc=jan.kiszka@siemens.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox