From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3492BC54E5D for ; Mon, 18 Mar 2024 11:35:54 +0000 (UTC) Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by mx.groups.io with SMTP id smtpd.web10.41297.1710761752818732743 for ; Mon, 18 Mar 2024 04:35:53 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=neutral (domain: denx.de, ip: 46.255.230.98, mailfrom: pavel@denx.de) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 497F71C007E; Mon, 18 Mar 2024 12:35:51 +0100 (CET) Date: Mon, 18 Mar 2024 12:35:50 +0100 From: Pavel Machek To: Lad Prabhakar Cc: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu , Pavel Machek , Biju Das Subject: Re: [PATCH 4.19.y-cip] memory: renesas-rpc-if: Clear HS bit during hardware initialization Message-ID: References: <20240315165231.31090-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eojxMg2JjENbxhI0" Content-Disposition: inline In-Reply-To: <20240315165231.31090-1-prabhakar.mahadev-lad.rj@bp.renesas.com> List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 18 Mar 2024 11:35:54 -0000 X-Groupsio-URL: https://lists.cip-project.org/g/cip-dev/message/15345 --eojxMg2JjENbxhI0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Cong Dang >=20 > commit 5192481f908e576be42bd39ec12979b79e11f7e0 upstream. >=20 > According to the datasheet, HS bit should be specified to 1 when using > DMA transfer. As DMA transfer is not supported, it should be cleared to > 0. >=20 > Previously, the driver relied on the HS bit being cleared by prior > firmware but this is not always the case. >=20 > Fix this by ensuring the bit is cleared during hardware > initialization. Patch looks ok to me, I can apply it if it passes testing and if there are no other comments. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --eojxMg2JjENbxhI0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZfgnFgAKCRAw5/Bqldv6 8t8pAJ4hwzZrYNe3V7f4Wh/yTZy8G/2K5wCgmkv8Wc9mUiDnQEXqeu7IWQXZ5uA= =3dTC -----END PGP SIGNATURE----- --eojxMg2JjENbxhI0--