Re: Backporting Renesas IA55 IRQC driver

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 2498 bytes --]

Hi!

> > and then arrange new_style_board to be set on machines you converted but
> > nowhere else. Best would be passing that information down the callchain
> > somehow, but you use have global variable or even config option...
> 
> IIUC the proposal here: the of_device_alloc() is called in the
> initialization phase, this being the call stack:
> 
> [    0.057410] Call trace:
> [    0.057438]  dump_backtrace+0x0/0x1c0
> [    0.057453]  show_stack+0x18/0x40
> [    0.057471]  dump_stack+0xe8/0x124
> [    0.057489]  of_device_alloc+0x54/0x1dc
> [    0.057501]  of_platform_device_create_pdata.part.0+0x24/0xc4
> [    0.057520]  of_platform_device_create_pdata+0x74/0xa0
> [    0.057533]  of_platform_bus_create+0x180/0x3e0
> [    0.057545]  of_platform_populate+0x58/0xfc
> [    0.057563]  of_platform_default_populate_init+0xb8/0xdc
> [    0.057576]  do_one_initcall+0x50/0x1c0
> [    0.057596]  kernel_init_freeable+0x230/0x298
> [    0.057609]  kernel_init+0x14/0x118
> [    0.057620]  ret_from_fork+0x10/0x38
> 
> while the IRQ driver is probed and used later, so, I cannot pass
> information from driver to of_device_alloc().
> 
> Based on your proposal, what about the following diff (or something
> similar)? Would it be acceptable for CIP:

This is just a warning workarond, AFAICT, so I guess more will be
needed and I'm not the only stakeholder. We'll need to see whole
series. But this sounds better than 1/ or 2/ alternatives proposed.

> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 43748c6480c8..ddbd46043d46 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -135,7 +135,8 @@ struct platform_device *of_device_alloc(struct device_node *np,
>                         rc = of_address_to_resource(np, i, res);
>                         WARN_ON(rc);
>                 }
> -               if (of_irq_to_resource_table(np, res, num_irq) != num_irq)
> +               if (!of_device_is_compatible(np, "renesas,rzg2l-irqc") &&
> +                   of_irq_to_resource_table(np, res, num_irq) != num_irq)
>                         pr_debug("not all legacy IRQ resources mapped for %pOFn\n",
>                                  np);
>         }
> 
> where "renesas,rzg2l-irqc" is the compatible for IA55 IRQ driver.

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]