* [PATCH 5.10.y-cip 1/7] dt-bindings: usb: renesas,usbhs: Document RZ/Five SoC
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 2/7] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
commit d990e227741692079872a8336d961ef4ab9e8aaf upstream.
The USBHS IP block on the RZ/Five SoC is identical to one found on the
RZ/G2UL SoC. "renesas,usbhs-r9a07g043" compatible string will be used on
the RZ/Five SoC so to make this clear and to keep this file consistent,
update the comment to include RZ/Five SoC.
No driver changes are required as generic compatible string
"renesas,rza2-usbhs" will be used as a fallback on RZ/Five SoC.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20231115211407.32067-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 18c301ef9698..0ce8f105b7d5 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -19,7 +19,7 @@ properties:
- items:
- enum:
- renesas,usbhs-r7s9210 # RZ/A2
- - renesas,usbhs-r9a07g043 # RZ/G2UL
+ - renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five
- renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
- renesas,usbhs-r9a07g054 # RZ/V2L
- const: renesas,rza2-usbhs
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 2/7] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 1/7] dt-bindings: usb: renesas,usbhs: Document RZ/Five SoC Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 3/7] usb: renesas_usbhs: Simplify obtaining device data Biju Das
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit c4f426460febadd10002248f579ee69374a4ef99 upstream.
The USBHS IP found on RZ/G2L SoCs only has 10 pipe buffers compared
to 16 pipe buffers on RZ/A2M. Document renesas,rzg2l-usbhs family
compatible to handle this difference for RZ/G2L family SoCs.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-2-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
index 0ce8f105b7d5..c83b6e8e2040 100644
--- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
+++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
@@ -19,10 +19,14 @@ properties:
- items:
- enum:
- renesas,usbhs-r7s9210 # RZ/A2
+ - const: renesas,rza2-usbhs
+
+ - items:
+ - enum:
- renesas,usbhs-r9a07g043 # RZ/G2UL and RZ/Five
- renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
- renesas,usbhs-r9a07g054 # RZ/V2L
- - const: renesas,rza2-usbhs
+ - const: renesas,rzg2l-usbhs
- items:
- enum:
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 3/7] usb: renesas_usbhs: Simplify obtaining device data
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 1/7] dt-bindings: usb: renesas,usbhs: Document RZ/Five SoC Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 2/7] dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 4/7] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers Biju Das
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit a79c5b6f675634387de8e88b0c85a053b9952970 upstream.
Simplify probe() by removing redundant dev->of_node check.
While at it, replace dev_err->dev_err_probe for error path.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-3-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 3af91b2b8f76..9196461e07ef 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -595,16 +595,11 @@ static int usbhs_probe(struct platform_device *pdev)
int ret;
u32 tmp;
- /* check device node */
- if (dev_of_node(dev))
- info = of_device_get_match_data(dev);
- else
- info = renesas_usbhs_get_info(pdev);
-
- /* check platform information */
+ info = of_device_get_match_data(dev);
if (!info) {
- dev_err(dev, "no platform information\n");
- return -EINVAL;
+ info = renesas_usbhs_get_info(pdev);
+ if (!info)
+ return dev_err_probe(dev, -EINVAL, "no platform info\n");
}
/* platform data */
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 4/7] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (2 preceding siblings ...)
2024-06-13 10:47 ` [PATCH 5.10.y-cip 3/7] usb: renesas_usbhs: Simplify obtaining device data Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 5/7] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit 790effae39cf368a9ff029406b8033ab6618ff90 upstream.
As per the hardware manual, double buffer setting results in fewer
interrupts for high-speed data transfers. Improve usbhsc_default_pipe[]
for isochronous transfers by updating the table from single->double
buffering and update the pipe number accordingly.
Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-4-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 9196461e07ef..4e0cf6b33bdb 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -366,11 +366,11 @@ static void usbhsc_clk_disable_unprepare(struct usbhs_priv *priv)
/* commonly used on old SH-Mobile SoCs */
static struct renesas_usbhs_driver_pipe_config usbhsc_default_pipe[] = {
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_CONTROL, 64, 0x00, false),
- RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, false),
- RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x18, false),
- RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x28, true),
- RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x38, true),
+ RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, true),
+ RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x28, true),
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x48, true),
+ RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x58, true),
+ RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_BULK, 512, 0x68, true),
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x04, false),
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x05, false),
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_INT, 64, 0x06, false),
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 5/7] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (3 preceding siblings ...)
2024-06-13 10:47 ` [PATCH 5.10.y-cip 4/7] usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous transfers Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 6/7] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table Biju Das
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit caf8fa1120c2fd9206cc1dfd58b8b55e0817238e upstream.
The RZ/G2L family SoCs has 10 pipe buffers compared to 16 pipe buffers on
RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and use
family SoC specific compatible to handle this difference.
The pipe configuration of RZ/G2L is same as usbhsc_rzg2l_default_pipe[],
so select the default pipe configuration for RZ/G2L SoCs by setting
.has_new_pipe_configs to zero.
Add SoC specific compatible to OF table to avoid ABI breakage with old
DTB. To optimize memory usage the SoC specific compatible will be removed
later.
Based on the patch in BSP by Huy Nguyen <huy.nguyen.wh@renesas.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-5-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 18 +++++++++++++++++-
drivers/usb/renesas_usbhs/rza.h | 1 +
drivers/usb/renesas_usbhs/rza2.c | 13 +++++++++++++
3 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 4e0cf6b33bdb..d9470e1d64b8 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -363,7 +363,7 @@ static void usbhsc_clk_disable_unprepare(struct usbhs_priv *priv)
* platform default param
*/
-/* commonly used on old SH-Mobile SoCs */
+/* commonly used on old SH-Mobile and RZ/G2L family SoCs */
static struct renesas_usbhs_driver_pipe_config usbhsc_default_pipe[] = {
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_CONTROL, 64, 0x00, false),
RENESAS_USBHS_PIPE(USB_ENDPOINT_XFER_ISOC, 1024, 0x08, true),
@@ -565,6 +565,18 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a77995",
.data = &usbhs_rcar_gen3_with_pll_plat_info,
},
+ {
+ .compatible = "renesas,usbhs-r9a07g043",
+ .data = &usbhs_rzg2l_plat_info,
+ },
+ {
+ .compatible = "renesas,usbhs-r9a07g044",
+ .data = &usbhs_rzg2l_plat_info,
+ },
+ {
+ .compatible = "renesas,usbhs-r9a07g054",
+ .data = &usbhs_rzg2l_plat_info,
+ },
{
.compatible = "renesas,rcar-gen2-usbhs",
.data = &usbhs_rcar_gen2_plat_info,
@@ -581,6 +593,10 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,rza2-usbhs",
.data = &usbhs_rza2_plat_info,
},
+ {
+ .compatible = "renesas,rzg2l-usbhs",
+ .data = &usbhs_rzg2l_plat_info,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, usbhs_of_match);
diff --git a/drivers/usb/renesas_usbhs/rza.h b/drivers/usb/renesas_usbhs/rza.h
index a29b75fef057..8b879aa34a20 100644
--- a/drivers/usb/renesas_usbhs/rza.h
+++ b/drivers/usb/renesas_usbhs/rza.h
@@ -3,3 +3,4 @@
extern const struct renesas_usbhs_platform_info usbhs_rza1_plat_info;
extern const struct renesas_usbhs_platform_info usbhs_rza2_plat_info;
+extern const struct renesas_usbhs_platform_info usbhs_rzg2l_plat_info;
diff --git a/drivers/usb/renesas_usbhs/rza2.c b/drivers/usb/renesas_usbhs/rza2.c
index 3eed3334a17f..1ffd19faf4e8 100644
--- a/drivers/usb/renesas_usbhs/rza2.c
+++ b/drivers/usb/renesas_usbhs/rza2.c
@@ -72,3 +72,16 @@ const struct renesas_usbhs_platform_info usbhs_rza2_plat_info = {
.has_new_pipe_configs = 1,
},
};
+
+const struct renesas_usbhs_platform_info usbhs_rzg2l_plat_info = {
+ .platform_callback = {
+ .hardware_init = usbhs_rza2_hardware_init,
+ .hardware_exit = usbhs_rza2_hardware_exit,
+ .power_ctrl = usbhs_rza2_power_ctrl,
+ .get_id = usbhs_get_id_as_gadget,
+ },
+ .driver_param = {
+ .has_cnen = 1,
+ .cfifo_byte_addr = 1,
+ },
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 6/7] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (4 preceding siblings ...)
2024-06-13 10:47 ` [PATCH 5.10.y-cip 5/7] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 10:47 ` [PATCH 5.10.y-cip 7/7] arm64: dts: renesas: r9a07g0{43,44,54}: Update RZ/G2L family compatible Biju Das
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit de9700f44d41d5ebdcbc0c5b5e1ffe7861eaffb1 upstream.
Remove the trailing comma in the terminator entry for the OF table
making code robust against (theoretical) misrebases or other similar
things where the new entry goes _after_ the termination without the
compiler noticing.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-6-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index d9470e1d64b8..1a963f853084 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -597,7 +597,7 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,rzg2l-usbhs",
.data = &usbhs_rzg2l_plat_info,
},
- { },
+ { }
};
MODULE_DEVICE_TABLE(of, usbhs_of_match);
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5.10.y-cip 7/7] arm64: dts: renesas: r9a07g0{43,44,54}: Update RZ/G2L family compatible
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (5 preceding siblings ...)
2024-06-13 10:47 ` [PATCH 5.10.y-cip 6/7] usb: renesas_usbhs: Remove trailing comma in the terminator entry for OF table Biju Das
@ 2024-06-13 10:47 ` Biju Das
2024-06-13 11:47 ` [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Pavel Machek
2024-06-14 5:23 ` nobuhiro1.iwamatsu
8 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2024-06-13 10:47 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das, Lad Prabhakar
commit 3bfe384f6f4f7433103ffcc36e7a7106f7e70c4e upstream.
The number of pipe buffers on RZ/G2L family SoCs is 10, whereas on RZ/A2M
it is 16. Replace 'renesas,rza2m-usbhs->renesas,rzg2l-usbhs' as family SoC
compatible to handle this difference and use the SoC specific compatible
in driver to avoid the ABI breakage with older DTB.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240319105356.87287-7-biju.das.jz@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
index 8721f4c9fa0f..766c54b91acc 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
@@ -812,7 +812,7 @@ usb2_phy1: usb-phy@11c70200 {
hsusb: usb@11c60000 {
compatible = "renesas,usbhs-r9a07g043",
- "renesas,rza2-usbhs";
+ "renesas,rzg2l-usbhs";
reg = <0 0x11c60000 0 0x10000>;
interrupts = <SOC_PERIPHERAL_IRQ(100) IRQ_TYPE_EDGE_RISING>,
<SOC_PERIPHERAL_IRQ(101) IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 9115d2ced33a..1ec12470c171 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -1092,7 +1092,7 @@ usb2_phy1: usb-phy@11c70200 {
hsusb: usb@11c60000 {
compatible = "renesas,usbhs-r9a07g044",
- "renesas,rza2-usbhs";
+ "renesas,rzg2l-usbhs";
reg = <0 0x11c60000 0 0x10000>;
interrupts = <GIC_SPI 100 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
index 769e87aa6886..ea1aba78335d 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
@@ -1099,7 +1099,7 @@ usb2_phy1: usb-phy@11c70200 {
hsusb: usb@11c60000 {
compatible = "renesas,usbhs-r9a07g054",
- "renesas,rza2-usbhs";
+ "renesas,rzg2l-usbhs";
reg = <0 0x11c60000 0 0x10000>;
interrupts = <GIC_SPI 100 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (6 preceding siblings ...)
2024-06-13 10:47 ` [PATCH 5.10.y-cip 7/7] arm64: dts: renesas: r9a07g0{43,44,54}: Update RZ/G2L family compatible Biju Das
@ 2024-06-13 11:47 ` Pavel Machek
2024-06-14 5:23 ` nobuhiro1.iwamatsu
8 siblings, 0 replies; 11+ messages in thread
From: Pavel Machek @ 2024-06-13 11:47 UTC (permalink / raw)
To: Biju Das; +Cc: cip-dev, Nobuhiro Iwamatsu, Pavel Machek, Lad Prabhakar
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
Hi!
> The USBHS IP found on RZ/G2L SoCs only has 10 pipe buffers compared to 16
> pipe buffers on RZ/A2M.
>
> Fix the USBHS Pipe configuration
>
> All the patches are cherry-picked from the mainline.
This looks ok to me. I can apply it if there are no other comments and
if it passes testing.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* RE: [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration
2024-06-13 10:47 [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Biju Das
` (7 preceding siblings ...)
2024-06-13 11:47 ` [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration Pavel Machek
@ 2024-06-14 5:23 ` nobuhiro1.iwamatsu
2024-06-14 9:29 ` Pavel Machek
8 siblings, 1 reply; 11+ messages in thread
From: nobuhiro1.iwamatsu @ 2024-06-14 5:23 UTC (permalink / raw)
To: biju.das.jz, cip-dev, pavel; +Cc: prabhakar.mahadev-lad.rj
Hi all,
> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Thursday, June 13, 2024 7:47 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○DITC□
> DIT○OST) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration
>
> The USBHS IP found on RZ/G2L SoCs only has 10 pipe buffers compared to 16
> pipe buffers on RZ/A2M.
>
> Fix the USBHS Pipe configuration
>
> All the patches are cherry-picked from the mainline.
>
> Biju Das (6):
> dt-bindings: usb: renesas,usbhs: Document RZ/G2L family compatible
> usb: renesas_usbhs: Simplify obtaining device data
> usb: renesas_usbhs: Improve usbhsc_default_pipe[] for isochronous
> transfers
> usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
> usb: renesas_usbhs: Remove trailing comma in the terminator entry for
> OF table
> arm64: dts: renesas: r9a07g0{43,44,54}: Update RZ/G2L family
> compatible
>
> Lad Prabhakar (1):
> dt-bindings: usb: renesas,usbhs: Document RZ/Five SoC
>
> .../bindings/usb/renesas,usbhs.yaml | 8 +++-
> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 2 +-
> drivers/usb/renesas_usbhs/common.c | 41
> ++++++++++++-------
> drivers/usb/renesas_usbhs/rza.h | 1 +
> drivers/usb/renesas_usbhs/rza2.c | 13 ++++++
> 7 files changed, 49 insertions(+), 20 deletions(-)
>
I reviewed this series, LGTM.
I can apppy this series, if there are no other comments.
Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5.10.y-cip 0/7] Fix USBHS pipe configuration
2024-06-14 5:23 ` nobuhiro1.iwamatsu
@ 2024-06-14 9:29 ` Pavel Machek
0 siblings, 0 replies; 11+ messages in thread
From: Pavel Machek @ 2024-06-14 9:29 UTC (permalink / raw)
To: nobuhiro1.iwamatsu; +Cc: biju.das.jz, cip-dev, pavel, prabhakar.mahadev-lad.rj
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
Hi!
> I reviewed this series, LGTM.
> I can apppy this series, if there are no other comments.
>
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Thanks for review, I added your reviewed-by tag and applied the
series.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread