Re: Request for reviews for 4.4-st54, 4.4-cip89

Pavel Machek
2024-07-04T19:25:02Z

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Hi!

> Here's the manual backports to review for the next 4.4 release which, as always, can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
>

Thanks for series. This one is a bit crazy, and wrong. Crazy because
it moves code for staging, and wrong because... it turns -ERANGE into
success. It should use 6.1 version of param_set_uint_minmax AFAICT.

+int param_set_uint_minmax(const char *val, const struct kernel_param *kp,
+ unsigned int min, unsigned int max)
+{
+ unsigned int num;
+ int ret;
+
+ if (!val)
+ return -EINVAL;
+ ret = kstrtouint(val, 0, &num);
+ if (ret == -EINVAL || num < min || num > max)
+ return -EINVAL;
+ *((unsigned int *)kp->arg) = num;
+ return 0;
+}
+EXPORT_SYMBOL_GPL(param_set_uint_minmax);

** m | 459de98d7 2a14c9 o | params: lift param_set_uint_minmax to
common code

The reset is okay AFAICT.

a | 62a95de44 30a92c o+ | openvswitch: Set the skbuff pkt_type for proper pmtud support.
a | 85b6bcf9d 52a2f0 o+ | net: usb: smsc95xx: fix changing LED_SEL bit value updated from EEPROM
a | 0049a623d b3dc6e o+ | ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound
a | 822ae5a8e f5d4e0 o+ | nilfs2: fix use-after-free of timer for log writer thread
a | f6141cbc2 1cd4bc o+ | vxlan: Fix regression when dropping packets due to invalid src addresses
a | 1ea3de272 1ed447 o | media: v4l2-core: hold videodev_lock until dev reg, finishes
a | 3c9ee8294 dfe6d1 o+ | KVM: arm64: Allow AArch32 PSTATE.M to be restored as System mode
a | 72c5d8e41 25460d o+ | net/9p: fix uninit-value in p9_client_rpc()

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]