Re: [PATCH 6.12.y-cip 03/10] soc: renesas: Add SYSC driver for Renesas RZ family

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

Hi!

> commit c1aca5588279fc341a2e12d61e853bb1fd4c72d5 upstream.
> 
> The RZ/G3S system controller (SYSC) has various registers that control
> different functionalities.  One of the exposed register offers
> information about the SoC identification.
> 
> Add a driver that identifies the SoC.  Later the driver will be extended
> with other functionalities.

Nitpick:

> +++ b/drivers/soc/renesas/rz-sysc.c
> +static int rz_sysc_soc_init(struct rz_sysc *sysc, const struct of_device_id *match)
> +{
> +	const struct rz_sysc_init_data *sysc_data = match->data;
> +	const struct rz_sysc_soc_id_init_data *soc_data = sysc_data->soc_id_init_data;
> +	struct soc_device_attribute *soc_dev_attr;
> +	const char *soc_id_start, *soc_id_end;
> +	u32 val, revision, specific_id;
> +	struct soc_device *soc_dev;
> +	char soc_id[32] = {0};
> +	size_t size;
> +
> +	soc_id_start = strchr(match->compatible, ',') + 1;
> +	soc_id_end = strchr(match->compatible, '-');
> +	size = soc_id_end - soc_id_start + 1;
> +	if (size > 32)
> +		size = sizeof(soc_id);

I'd expect sizeof(soc_id) instead of 32... or maybe 32 in both places,
or maybe const int max_size = 32, and then using it three times.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]