Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

Hi!

> > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> > 
> > When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and
> > shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU
> > bring-up fails:
> > 
> >     smp: Bringing up secondary CPUs ...
> >     CPU1: failed to come online
> >     CPU2: failed to come online
> >     CPU3: failed to come online
> >     smp: Brought up 1 node, 1 CPU
> > 
> > Fix this by adding the missing alignment directive.
> > 
> > Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,
> > arg}[] from .text to .bss")
> > Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> > Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Link:
> > https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
> > 8.git.geert+renesas@glider.be
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Hi All,
> > 
> > Note:
> > - This issue has been replicated on 4.4-cip with older compilers and
> > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> > - The offending commit 4e960f52fce16a3b is not present in v4.4 release so
> > this patch wont be backported into 4.4-cip by stable hence just sending
> > this for 4.4-cip only. Please note this patch has been cherry-picked v6.14
> > release.
> >
> Gentle ping for review.

I could not find traces of the email in my mail archives. Strange.

Anyway, adding alignment is unlikely to hurt anything, and patch looks
ok to me.

Reviewed-by: Pavel Machek <pavel@denx.de>

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]