RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Prabhakar Mahadev Lad]

Hi All,

> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
> Behalf Of Lad Prabhakar via lists.cip-project.org
> Sent: 04 April 2025 10:58
> To: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> shmobile_smp_* alignment
> 
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> 
> When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and
> shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU
> bring-up fails:
> 
>     smp: Bringing up secondary CPUs ...
>     CPU1: failed to come online
>     CPU2: failed to come online
>     CPU3: failed to come online
>     smp: Brought up 1 node, 1 CPU
> 
> Fix this by adding the missing alignment directive.
> 
> Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,
> arg}[] from .text to .bss")
> Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Link:
> https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
> 8.git.geert+renesas@glider.be
> Cc: stable@vger.kernel.org
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Hi All,
> 
> Note:
> - This issue has been replicated on 4.4-cip with older compilers and
> CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> - The offending commit 4e960f52fce16a3b is not present in v4.4 release so
> this patch wont be backported into 4.4-cip by stable hence just sending
> this for 4.4-cip only. Please note this patch has been cherry-picked v6.14
> release.
>
Gentle ping for review.

Cheers,
Prabhakar

RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[nobuhiro1.iwamatsu]

Hi Prabhakar, 

Sorry for review is too late.

> -----Original Message-----
> From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Sent: Wednesday, April 16, 2025 7:56 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>; cip-dev@lists.cip-project.org
> Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> shmobile_smp_* alignment
> 
> Hi All,
> 
> > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
> > Behalf Of Lad Prabhakar via lists.cip-project.org
> > Sent: 04 April 2025 10:58
> > To: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
> > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>
> > Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > shmobile_smp_* alignment
> >
> > From: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> >
> > When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and
> > shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU
> > bring-up fails:
> >
> >     smp: Bringing up secondary CPUs ...
> >     CPU1: failed to come online
> >     CPU2: failed to come online
> >     CPU3: failed to come online
> >     smp: Brought up 1 node, 1 CPU
> >
> > Fix this by adding the missing alignment directive.
> >
> > Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,
> > arg}[] from .text to .bss")
> > Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> > Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Link:
> >
> https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416
> > 1220
> > 8.git.geert+renesas@glider.be
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Hi All,
> >
> > Note:
> > - This issue has been replicated on 4.4-cip with older compilers and
> > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> > - The offending commit 4e960f52fce16a3b is not present in v4.4 release
> > so this patch wont be backported into 4.4-cip by stable hence just
> > sending this for 4.4-cip only. Please note this patch has been
> > cherry-picked v6.14 release.
> >
> Gentle ping for review.
> 

LGTM.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro

RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Prabhakar Mahadev Lad]

Hi Iwamatsu-san,

> -----Original Message-----
> From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp>
> Sent: 17 April 2025 07:05
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> pavel@denx.de
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; cip-dev@lists.cip-project.org
> Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> shmobile_smp_* alignment
> 
> Hi Prabhakar,
> 
> Sorry for review is too late.
> 
> > -----Original Message-----
> > From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Sent: Wednesday, April 16, 2025 7:56 PM
> > To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > cip-dev@lists.cip-project.org
> > Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > shmobile_smp_* alignment
> >
> > Hi All,
> >
> > > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org>
> > > On Behalf Of Lad Prabhakar via lists.cip-project.org
> > > Sent: 04 April 2025 10:58
> > > To: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
> > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > > Cc: Biju Das <biju.das.jz@bp.renesas.com>
> > > Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > > shmobile_smp_* alignment
> > >
> > > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> > >
> > > When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and
> > > shmobile_smp_arg variables are not multiples of 4 bytes, secondary
> > > CPU bring-up fails:
> > >
> > >     smp: Bringing up secondary CPUs ...
> > >     CPU1: failed to come online
> > >     CPU2: failed to come online
> > >     CPU3: failed to come online
> > >     smp: Brought up 1 node, 1 CPU
> > >
> > > Fix this by adding the missing alignment directive.
> > >
> > > Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr,
> > > fn, arg}[] from .text to .bss")
> > > Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> > > Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Link:
> > >
> > https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.17416
> > > 1220
> > > 8.git.geert+renesas@glider.be
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > Hi All,
> > >
> > > Note:
> > > - This issue has been replicated on 4.4-cip with older compilers and
> > > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> > > - The offending commit 4e960f52fce16a3b is not present in v4.4
> > > release so this patch wont be backported into 4.4-cip by stable
> > > hence just sending this for 4.4-cip only. Please note this patch has
> > > been cherry-picked v6.14 release.
> > >
> > Gentle ping for review.
> >
> 
> LGTM.
> 
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> 
Thank you for the review. This patch is missing in 4.4-cip.

Cheers,
Prabhakar

RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[nobuhiro1.iwamatsu]

Hi,

> > > Gentle ping for review.
> > >
> >
> > LGTM.
> >
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> >
> Thank you for the review. This patch is missing in 4.4-cip.

Perhaps Uli does not notice because he is not in TO and CC.

Uli, could you pick this patch to next 4.4.y-cip release?

Best regards.
  Nobuhiro

> -----Original Message-----
> From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Sent: Monday, April 28, 2025 4:40 AM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; cip-dev@lists.cip-project.org
> Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> shmobile_smp_* alignment
> 
> Hi Iwamatsu-san,
> 
> > -----Original Message-----
> > From: nobuhiro1.iwamatsu@toshiba.co.jp
> > <nobuhiro1.iwamatsu@toshiba.co.jp>
> > Sent: 17 April 2025 07:05
> > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > pavel@denx.de
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>;
> > cip-dev@lists.cip-project.org
> > Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > shmobile_smp_* alignment
> >
> > Hi Prabhakar,
> >
> > Sorry for review is too late.
> >
> > > -----Original Message-----
> > > From: Prabhakar Mahadev Lad
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Sent: Wednesday, April 16, 2025 7:56 PM
> > > To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > > cip-dev@lists.cip-project.org
> > > Subject: RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > > shmobile_smp_* alignment
> > >
> > > Hi All,
> > >
> > > > From: cip-dev@lists.cip-project.org
> > > > <cip-dev@lists.cip-project.org> On Behalf Of Lad Prabhakar via
> > > > lists.cip-project.org
> > > > Sent: 04 April 2025 10:58
> > > > To: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu
> > > > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> > > > Cc: Biju Das <biju.das.jz@bp.renesas.com>
> > > > Subject: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> > > > shmobile_smp_* alignment
> > > >
> > > > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> > > >
> > > > When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn,
> and
> > > > shmobile_smp_arg variables are not multiples of 4 bytes, secondary
> > > > CPU bring-up fails:
> > > >
> > > >     smp: Bringing up secondary CPUs ...
> > > >     CPU1: failed to come online
> > > >     CPU2: failed to come online
> > > >     CPU3: failed to come online
> > > >     smp: Brought up 1 node, 1 CPU
> > > >
> > > > Fix this by adding the missing alignment directive.
> > > >
> > > > Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move
> shmobile_smp_{mpidr,
> > > > fn, arg}[] from .text to .bss")
> > > > Closes:
> https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> > > > Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Tested-by: Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > Link:
> > > >
> > >
> https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174
> > > 16
> > > > 1220
> > > > 8.git.geert+renesas@glider.be
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > ---
> > > > Hi All,
> > > >
> > > > Note:
> > > > - This issue has been replicated on 4.4-cip with older compilers
> > > > and CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> > > > - The offending commit 4e960f52fce16a3b is not present in v4.4
> > > > release so this patch wont be backported into 4.4-cip by stable
> > > > hence just sending this for 4.4-cip only. Please note this patch
> > > > has been cherry-picked v6.14 release.
> > > >
> > > Gentle ping for review.
> > >
> >
> > LGTM.
> >
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> >
> Thank you for the review. This patch is missing in 4.4-cip.
> 
> Cheers,
> Prabhakar

Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

Hi!

> > From: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > commit 379c590113ce46f605439d4887996c60ab8820cc upstream.
> > 
> > When the addresses of the shmobile_smp_mpidr, shmobile_smp_fn, and
> > shmobile_smp_arg variables are not multiples of 4 bytes, secondary CPU
> > bring-up fails:
> > 
> >     smp: Bringing up secondary CPUs ...
> >     CPU1: failed to come online
> >     CPU2: failed to come online
> >     CPU3: failed to come online
> >     smp: Brought up 1 node, 1 CPU
> > 
> > Fix this by adding the missing alignment directive.
> > 
> > Fixes: 4e960f52fce16a3b ("ARM: shmobile: Move shmobile_smp_{mpidr, fn,
> > arg}[] from .text to .bss")
> > Closes: https://lore.kernel.org/r/CAMuHMdU=QR-JLgEHKWpsr6SbaZRc-
> > Hz9r91JfpP8c3n2G-OjqA@mail.gmail.com
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Link:
> > https://lore.kernel.org/c499234d559a0d95ad9472883e46077311051cd8.174161220
> > 8.git.geert+renesas@glider.be
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Hi All,
> > 
> > Note:
> > - This issue has been replicated on 4.4-cip with older compilers and
> > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE enabled.
> > - The offending commit 4e960f52fce16a3b is not present in v4.4 release so
> > this patch wont be backported into 4.4-cip by stable hence just sending
> > this for 4.4-cip only. Please note this patch has been cherry-picked v6.14
> > release.
> >
> Gentle ping for review.

I could not find traces of the email in my mail archives. Strange.

Anyway, adding alignment is unlikely to hurt anything, and patch looks
ok to me.

Reviewed-by: Pavel Machek <pavel@denx.de>

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Ulrich Hecht]

> On 05/07/2025 2:55 AM CEST Nobuhiro Iwamatsu via lists.cip-project.org <nobuhiro1.iwamatsu=toshiba.co.jp@lists.cip-project.org> wrote:
> > > > Gentle ping for review.
> > > LGTM.
> > >
> > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > >
> > Thank you for the review. This patch is missing in 4.4-cip.
> 
> Perhaps Uli does not notice because he is not in TO and CC.

Yes, please include me when sending patches for 4.4 and 4.19 kernels.

> Uli, could you pick this patch to next 4.4.y-cip release?

Can do. Am I correct to assume that this is specifically for -cip and does not apply to -st?

CU
Uli

RE: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce shmobile_smp_* alignment

[Prabhakar Mahadev Lad]

Hi Ulrich,

> -----Original Message-----
> From: Ulrich Hecht <uli@fpond.eu>
> Sent: 07 May 2025 09:45
> To: nobuhiro1.iwamatsu@toshiba.co.jp; Nobuhiro Iwamatsu via lists.cip-
> project.org <nobuhiro1.iwamatsu=toshiba.co.jp@lists.cip-project.org>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; cip-dev@lists.cip-project.org;
> pavel@denx.de
> Subject: Re: [cip-dev] [PATCH 4.4.y-cip] ARM: shmobile: smp: Enforce
> shmobile_smp_* alignment
> 
> 
> > On 05/07/2025 2:55 AM CEST Nobuhiro Iwamatsu via lists.cip-project.org
> <nobuhiro1.iwamatsu=toshiba.co.jp@lists.cip-project.org> wrote:
> > > > > Gentle ping for review.
> > > > LGTM.
> > > >
> > > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > > >
> > > Thank you for the review. This patch is missing in 4.4-cip.
> >
> > Perhaps Uli does not notice because he is not in TO and CC.
> 
> Yes, please include me when sending patches for 4.4 and 4.19 kernels.
> 
Sure, I will take care of it next time.

> > Uli, could you pick this patch to next 4.4.y-cip release?
> 
> Can do. Am I correct to assume that this is specifically for -cip and does
> not apply to -st?
> 
Yes for -cip, the offending commit 4e960f52fce16a3b is not present in v4.4
release so this patch wont be backported into 4.4-cip by stable hence just
sending this for 4.4-cip only.

Cheers,
Prabhakar