Request for review for 4.4-st65, 4.4-cip100

Request for review for 4.4-st65, 4.4-cip100

[Ulrich Hecht]

Hi!

Here's the manual backports for the upcoming 4.4 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc

8dab9bb642b2e net_sched: hfsc: Fix a potential UAF in hfsc_dequeue() too
6f43c571bf094 of/irq: Fix device node refcount leakages in of_irq_init()
7f406a4c1fd70 mm: add missing release barrier on PGDAT_RECLAIM_LOCKED unlock
d24045205aaa7 media: streamzap: prevent processing IR data on URB failure

Thanks for having a look!

CU
Uli

RE: Request for review for 4.4-st65, 4.4-cip100

[nobuhiro1.iwamatsu]

Hi Ulrich,

> -----Original Message-----
> From: Ulrich Hecht <uli@fpond.eu>
> Sent: Tuesday, June 17, 2025 1:55 AM
> To: cip-dev@lists.cip-project.org; pavel@denx.de; iwamatsu nobuhiro(岩松 信
> 洋 □ＤＩＴＣ○ＣＰＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Subject: Request for review for 4.4-st65, 4.4-cip100
> 
> Hi!
> 
> Here's the manual backports for the upcoming 4.4 kernel release. As always
> they can be found in
> https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linu
> x-4.4.y-st-rc
> 
> 8dab9bb642b2e net_sched: hfsc: Fix a potential UAF in hfsc_dequeue() too
> 6f43c571bf094 of/irq: Fix device node refcount leakages in of_irq_init()
> 7f406a4c1fd70 mm: add missing release barrier on PGDAT_RECLAIM_LOCKED
> unlock
> d24045205aaa7 media: streamzap: prevent processing IR data on URB failure
> 
> Thanks for having a look!
> 

Thanks for you update!
I checked this update. looks good to me.

Best regards,
  Nobuhiro

Re: Request for review for 4.4-st65, 4.4-cip100

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi!

> Here's the manual backports for the upcoming 4.4 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
>

One patch is not complete, the rest look ok to me.

a > 8dab9bb642b2e net_sched: hfsc: Fix a potential UAF in hfsc_dequeue() too
> 6f43c571bf094 of/irq: Fix device node refcount leakages in
> of_irq_init()

4.4 has one more place to handle, AFAICT:

                        if (WARN(!match->data,
                            "of_irq_init: no init function for %s\n",
                            match->compatible)) {
                                kfree(desc);
                                continue;
			}

(Being behind WARN(), it is probably not too important).

a > 7f406a4c1fd70 mm: add missing release barrier on PGDAT_RECLAIM_LOCKED unlock
a > d24045205aaa7 media: streamzap: prevent processing IR data on URB failure

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Indirect Target Selection (CVE-2024-28956) Re: Request for review for 4.4-st65, 4.4-cip100

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

Hi!

> Here's the manual backports for the upcoming 4.4 kernel release. As always they can be found in https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-4.4.y-st-rc
> 
> 8dab9bb642b2e net_sched: hfsc: Fix a potential UAF in hfsc_dequeue() too
> 6f43c571bf094 of/irq: Fix device node refcount leakages in of_irq_init()
> 7f406a4c1fd70 mm: add missing release barrier on PGDAT_RECLAIM_LOCKED unlock
> d24045205aaa7 media: streamzap: prevent processing IR data on URB failure
> 
> Thanks for having a look!

Should we add something like this?

Does anyone care deeply about ITS bugs? If so, talk to me, and we can
cooperate on deeper investigation.

Best regards,
								Pavel

---

Document that ITS workarounds are not present in 4.4-cip.

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/KNOWN-BUGS b/KNOWN-BUGS
index ec2de4aab685e..b268e54bc96e4 100644
--- a/KNOWN-BUGS
+++ b/KNOWN-BUGS
@@ -19,6 +19,10 @@ architectures.
 Random rewrite from 4.9.320 was not backported. We have seen no good
 explanation why it is needed, and it is rather intrusive.
 
+Workarounds for Intel Indirect Target Selection (CVE-2024-28956) bugs
+were not backported to 5.10-stable and older, and so are not present
+in here, either.
+
 These commits were not backported and may need more investigation:
 
 be8173bc1 | mm: fix race between MADV_FREE reclaim and blkdev direct IO read


-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [cip-dev] Indirect Target Selection (CVE-2024-28956) Re: Request for review for 4.4-st65, 4.4-cip100

[Ulrich Hecht]

> On 06/17/2025 12:20 PM CEST Pavel Machek via lists.cip-project.org <pavel=denx.de@lists.cip-project.org> wrote:
> Should we add something like this?
> 
[...]
> ---
> 
> Document that ITS workarounds are not present in 4.4-cip.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/KNOWN-BUGS b/KNOWN-BUGS
> index ec2de4aab685e..b268e54bc96e4 100644
> --- a/KNOWN-BUGS
> +++ b/KNOWN-BUGS
> @@ -19,6 +19,10 @@ architectures.
>  Random rewrite from 4.9.320 was not backported. We have seen no good
>  explanation why it is needed, and it is rather intrusive.
>  
> +Workarounds for Intel Indirect Target Selection (CVE-2024-28956) bugs
> +were not backported to 5.10-stable and older, and so are not present
> +in here, either.
> +

I guess that can't hurt. I'll add it.

CU
Uli